Menu link saved with invalid link_options data when using Menu Attributes module

hitfactory → closed merge request !3

hitfactory → reopened merge request !3

hitfactory → changed the visibility of the branch 3417145-menu-link-saved to hidden.

hitfactory → closed merge request !3

Sorry for the clutter. I couldn't work out how to delete the merge request against the wrong branch and only figured out later I could change the branch without creating a new one.

To add a bit more context, this happens because the Attributes fieldset which displays via the Menu Link Attributes module may not always be visible to the end user if they don't have the ''use menu link attributes' permission.

When a user doesn't have the ''use menu link attributes' permission, then the $menu_link_options variable passed as the first argument to array_merge_recursive in simple_megamenu_menu_link_content_form_submit will be identical to the second argument $data_simple_mega_menu.

We're running into the same issue now!

@hitfactory did you also test your MR works without the Menu Attributes module?
Code-wise I'd say it won't?

Anybody → changed the visibility of the branch 3417145-fix to hidden.