+1 for this idea.
In our case, we need to send a thank you email to anonymous users without any links so the access check shouldn't even need to run.
I applied the patch on a new site with the module and the new configuration property bypass_anonymous_access was saved on the notification configuration entity, but on an existing site, it doesn't seem to persist.
Perhaps an update hook is also required to add the property and set it to false on existing notifications?
Updated patch for 2.0.x-dev which also handles excluded form IDs.
Sorry for the clutter. I couldn't work out how to delete the merge request against the wrong branch and only figured out later I could change the branch without creating a new one.
To add a bit more context, this happens because the Attributes fieldset which displays via the Menu Link Attributes module may not always be visible to the end user if they don't have the ''use menu link attributes' permission.
When a user doesn't have the ''use menu link attributes' permission, then the $menu_link_options variable passed as the first argument to array_merge_recursive in simple_megamenu_menu_link_content_form_submit will be identical to the second argument $data_simple_mega_menu.
hitfactory → changed the visibility of the branch 3417145-menu-link-saved to hidden.
hitfactory → created an issue.
Can you provide a link to the comment on the MR as I can't seem to find it?
hitfactory → created an issue.
Also encountered this bug and can confirm the patch resolved it.