- Issue created by @amateescu
- π·π΄Romania amateescu
This should do it.
This validation tested in
\Drupal\Tests\content_moderation\Kernel\ContentModerationWorkflowConfigTest::testDeletingStateViaConfiguration()
, but I don't think that adding specific test coverage for this bug would add any real value to that test. - Merge request !6264Fix Content Moderation broad workflow type validation. β (Open) created by amateescu
- Status changed to Needs review
11 months ago 9:44am 22 January 2024 - Status changed to RTBC
11 months ago 8:00pm 24 January 2024 - πΊπΈUnited States smustgrave
Believe it makes sense to only operate on content_moderation plugins in the content_moderation module. M
- π³πΏNew Zealand quietone
I'm triaging RTBC issues β . I read the IS and the comments.
The only question here is whether a test is needed. By current policy a test is needed but I understand the point made in #2. I'll leave this at RTBC and let another committer express an opinion.
- Status changed to Fixed
10 months ago 11:28am 1 March 2024 - π¬π§United Kingdom catch
Yeah I agree the extra coverage is not useful here - we'd be testing that something that used to happen doesn't happen any more, but not actually adding more code coverage - the new condition is covered by the existing coverage.
Automatically closed - issue fixed for 2 weeks with no activity.