- Issue created by @danrod
- Assigned to danrod
- First commit to issue fork.
- First commit to issue fork.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 4:12pm 22 January 2024 - Status changed to Active
about 1 year ago 9:22pm 23 January 2024 - Assigned to pray_12
- Status changed to Needs work
about 1 year ago 8:45am 24 January 2024 - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 5:41am 25 January 2024 - 🇨🇦Canada danrod Ottawa
I'm seeing an issue when trying to edit Calendar Events or Calendars:
TypeError: Drupal\google_calendar_service\Form\CalendarForm::__construct(): Argument #2 ($entity_type_manager) must be of type Drupal\Core\Entity\EntityTypeManagerInterface, Drupal\Core\Entity\EntityTypeBundleInfo given, called in /var/www/html/web/modules/contrib/google_calendar_service/src/Form/CalendarForm.php on line 84 in Drupal\google_calendar_service\Form\CalendarForm->__construct() (line 59 of /var/www/html/web/modules/contrib/google_calendar_service/src/Form/CalendarForm.php).
I'll push a change to fix this.
- Status changed to Needs work
about 1 year ago 11:00pm 29 January 2024 - Status changed to Needs review
about 1 year ago 11:12pm 29 January 2024 - 🇨🇦Canada danrod Ottawa
I ran phpcs again and I don't see any issues as well:
$ phpcs -v --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/google_calendar_service/ Registering sniffs in the Drupal standard... DONE (125 sniffs registered) Creating file list... DONE (36 files in queue) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service Processing google_calendar_service.links.menu.yml [PHP => 19 tokens in 19 lines]... DONE in 5ms (0 errors, 0 warnings) Processing google_calendar_service.links.action.yml [PHP => 11 tokens in 11 lines]... DONE in 0ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/config/install Processing views.view.gcs_calendar_events.yml [PHP => 1336 tokens in 1336 lines]... DONE in 8ms (0 errors, 0 warnings) Processing google_calendar_service.default.yml [PHP => 2 tokens in 2 lines]... DONE in 0ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service Processing README.md [PHP => 69 tokens in 69 lines]... DONE in 0ms (0 errors, 0 warnings) Processing google_calendar_service.install [PHP => 190 tokens in 33 lines]... DONE in 4ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src Processing CalendarListBuilder.php [PHP => 625 tokens in 87 lines]... DONE in 8ms (0 errors, 0 warnings) Processing CalendarEventAccessControlHandler.php [PHP => 341 tokens in 70 lines]... DONE in 5ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Entity Processing CalendarEventInterface.php [PHP => 451 tokens in 94 lines]... DONE in 5ms (0 errors, 0 warnings) Processing CalendarEvent.php [PHP => 2410 tokens in 361 lines]... DONE in 32ms (0 errors, 0 warnings) Processing CalendarViewsData.php [PHP => 89 tokens in 20 lines]... DONE in 1ms (0 errors, 0 warnings) Processing Calendar.php [PHP => 1910 tokens in 301 lines]... DONE in 25ms (0 errors, 0 warnings) Processing CalendarInterface.php [PHP => 509 tokens in 107 lines]... DONE in 6ms (0 errors, 0 warnings) Processing CalendarEventViewsData.php [PHP => 89 tokens in 20 lines]... DONE in 1ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Plugin/Validation/Constraint Processing TimeAvailableConstraintValidator.php [PHP => 745 tokens in 100 lines]... DONE in 10ms (0 errors, 0 warnings) Processing TimeAvailableConstraint.php [PHP => 155 tokens in 33 lines]... DONE in 2ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Plugin/QueueWorker Processing CalendarImportProcessor.php [PHP => 380 tokens in 70 lines]... DONE in 5ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src Processing GoogleHttpClientFactory.php [PHP => 467 tokens in 82 lines]... DONE in 6ms (0 errors, 0 warnings) Processing CalendarAccessControlHandler.php [PHP => 341 tokens in 70 lines]... DONE in 5ms (0 errors, 0 warnings) Processing CalendarEventListBuilder.php [PHP => 379 tokens in 57 lines]... DONE in 5ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Form Processing ImportEventsForm.php [PHP => 947 tokens in 163 lines]... DONE in 12ms (0 errors, 0 warnings) Processing CalendarEventDeleteForm.php [PHP => 745 tokens in 121 lines]... DONE in 10ms (0 errors, 0 warnings) Processing CalendarForm.php [PHP => 846 tokens in 141 lines]... DONE in 12ms (0 errors, 0 warnings) Processing CalendarSettingsForm.php [PHP => 1852 tokens in 306 lines]... DONE in 25ms (0 errors, 0 warnings) Processing CalendarEventForm.php [PHP => 1849 tokens in 271 lines]... DONE in 26ms (0 errors, 0 warnings) Processing CalendarDeleteForm.php [PHP => 311 tokens in 51 lines]... DONE in 5ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src Processing CalendarHtmlRouteProvider.php [PHP => 335 tokens in 53 lines]... DONE in 5ms (0 errors, 0 warnings) Processing CalendarEditEvents.php [PHP => 1958 tokens in 297 lines]... DONE in 24ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Controller Processing CalendarImportController.php [PHP => 883 tokens in 155 lines]... DONE in 12ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src Processing CalendarImport.php [PHP => 2271 tokens in 345 lines]... DONE in 30ms (0 errors, 0 warnings) Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service Processing google_calendar_service.services.yml [PHP => 16 tokens in 16 lines]... DONE in 0ms (0 errors, 0 warnings) Processing google_calendar_service.module [PHP => 538 tokens in 84 lines]... DONE in 7ms (0 errors, 0 warnings) Processing google_calendar_service.links.task.yml [PHP => 31 tokens in 31 lines]... DONE in 0ms (0 errors, 0 warnings) Processing google_calendar_service.routing.yml [PHP => 44 tokens in 44 lines]... DONE in 0ms (0 errors, 0 warnings) Processing google_calendar_service.info.yml [PHP => 9 tokens in 9 lines]... DONE in 3ms (0 errors, 0 warnings) Processing google_calendar_service.permissions.yml [PHP => 31 tokens in 31 lines]... DONE in 0ms (0 errors, 0 warnings) $
I changed the issue to "Needs Review" in case anyone wants to review my changes as well.
-
danrod →
committed 6bff2219 on 3.0.x authored by
apaderno →
Resolve #3416145 "Fix the issues"
-
danrod →
committed 6bff2219 on 3.0.x authored by
apaderno →
- 🇨🇦Canada danrod Ottawa
Merged to the 3.0.x branch, thanks a lot to everyone involved on this!
- Status changed to RTBC
about 1 year ago 1:33am 31 January 2024 - Status changed to Fixed
about 1 year ago 1:37am 31 January 2024 -
danrod →
committed 6bff2219 on 8.x-2.x authored by
apaderno →
Resolve #3416145 "Fix the issues"
-
danrod →
committed 6bff2219 on 8.x-2.x authored by
apaderno →
Automatically closed - issue fixed for 2 weeks with no activity.