Fix the issues reported by phpcs

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/google_calendar_service/ FILE: .../drupal-components-library/web/modules/contrib/google_calendar_service/config/install/views.view.gcs_calendar_events.yml ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 1336 | ERROR | [x] Expected 1 newline at end of file; 2 found ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/README.md ----------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------- 42 | WARNING | Line exceeds 80 characters; contains 423 characters 43 | WARNING | Line exceeds 80 characters; contains 209 characters 45 | WARNING | Line exceeds 80 characters; contains 112 characters 47 | WARNING | Line exceeds 80 characters; contains 275 characters ----------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/google_calendar_service.install --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 15 | ERROR | [x] Whitespace found at end of line --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/CalendarListBuilder.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link. 31 | WARNING | [x] Inline @var declarations should use the /** */ delimiters 33 | WARNING | [ ] Only string literals should be passed to t() where possible ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/CalendarEventAccessControlHandler.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Access\AccessResult. 25 | WARNING | [x] Inline @var declarations should use the /** */ delimiters ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/Entity/CalendarEvent.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityBase. 60 | ERROR | [x] Expected 2 spaces before interface name; 4 found ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/Entity/Calendar.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityBase. ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: ...pal-components-library/web/modules/contrib/google_calendar_service/src/Plugin/Validation/Constraint/TimeAvailableConstraintValidator.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\Core\DependencyInjection\ContainerInjectionInterface. 19 | ERROR | [ ] Missing short description in doc comment 43 | ERROR | [ ] Class property $EditEventService should use lowerCamel naming without underscores 45 | ERROR | [ ] Parameter $edit_events is not described in comment 52 | ERROR | [ ] Doc comment for parameter $route_match does not match actual variable name $edit_events ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: ...sites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Plugin/Validation/Constraint/TimeAvailableConstraint.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 19 | ERROR | [x] You must use "/**" style comments for a member variable comment ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: ...daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Plugin/QueueWorker/CalendarImportProcessor.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 7 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 4 | ERROR | [x] Doc comment short description must end with a full stop 9 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 26 | ERROR | [x] Expected 2 spaces before interface name; 0 found 35 | ERROR | [ ] Parameter $configuration is not described in comment 35 | ERROR | [ ] Parameter $plugin_id is not described in comment 35 | ERROR | [ ] Parameter $plugin_definition is not described in comment ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/GoogleHttpClientFactory.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------- 5 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Google_Service_Calendar. 7 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 15 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/CalendarAccessControlHandler.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Access\AccessResult. 25 | WARNING | [x] Inline @var declarations should use the /** */ delimiters -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/CalendarEventListBuilder.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------- 28 | WARNING | [x] Inline @var declarations should use the /** */ delimiters ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/Form/ImportEventsForm.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\google_calendar_service\CalendarImport. --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/Form/CalendarEventDeleteForm.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeBundleInfoInterface. 28 | ERROR | [ ] Missing short description in doc comment 40 | ERROR | [ ] Doc comment for parameter $bundle_info does not match actual variable name <undefined> ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/Form/CalendarForm.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeBundleInfoInterface. 36 | ERROR | [ ] Missing short description in doc comment 48 | ERROR | [ ] Doc comment for parameter $bundle_info does not match actual variable name <undefined> 89 | WARNING | [x] Inline @var declarations should use the /** */ delimiters --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/Form/CalendarSettingsForm.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityFieldManager. 19 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 29 | ERROR | [ ] Missing short description in doc comment 118 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/Form/CalendarEventForm.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeBundleInfoInterface. 14 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 47 | ERROR | [ ] Missing short description in doc comment 59 | ERROR | [ ] Doc comment for parameter $bundle_info does not match actual variable name <undefined> 105 | WARNING | [x] Inline @var declarations should use the /** */ delimiters ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/CalendarEditEvents.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface. 9 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 10 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 11 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 253 | ERROR | [ ] Parameter $eventId is not described in comment ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/Controller/CalendarImportController.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\google_calendar_service\CalendarImport. 15 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 39 | ERROR | [ ] Missing short description in doc comment 127 | ERROR | [x] Additional blank lines found at end of doc comment --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/src/CalendarImport.php ------------------------------------------------------------------------------------------------------------------------ FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES ------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 10 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 11 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is DateTime. 12 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 13 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 20 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 275 | ERROR | [x] Use null coalesce operator instead of ternary operator. ------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------ FILE: /home/drupal-components-library/web/modules/contrib/google_calendar_service/google_calendar_service.module ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 20 ERRORS AFFECTING 14 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Render\Element. 32 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "_save_google_event_form_submit" but | | expected "google_calendar_service__save_google_event_form_submit" 32 | ERROR | [x] Missing function doc comment 65 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "_validate_time_save_google_event" | | but expected "google_calendar_service__validate_time_save_google_event" 65 | ERROR | [x] Missing function doc comment 83 | ERROR | [x] No space found before comment text; expected "// Error message set in verifyTimeGoogleCalendar method." but found "//Error | | message set in verifyTimeGoogleCalendar method." 107 | ERROR | [x] Expected 1 blank line after function; 2 found 119 | ERROR | [x] Missing function doc comment 119 | ERROR | [x] Expected 1 blank line before function; 0 found 149 | ERROR | [x] Object operator not indented correctly; expected 6 spaces but found 12 154 | ERROR | [x] Whitespace found at end of line 178 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 179 | ERROR | [x] Missing function doc comment 179 | ERROR | [x] Expected 1 blank line before function; 0 found 198 | ERROR | [x] Expected 1 blank line after function; 2 found 243 | ERROR | [x] Concat operator must be surrounded by a single space 243 | ERROR | [x] Concat operator must be surrounded by a single space 244 | ERROR | [x] Concat operator must be surrounded by a single space 244 | ERROR | [x] Concat operator must be surrounded by a single space 247 | ERROR | [x] Expected 1 newline at end of file; 2 found ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @danrod
Assigned to danrod
Comment 5 months ago →
🇨🇦Canada danrod
First commit to issue fork.
First commit to issue fork.
Merge request !12Resolve #3416145 "Fix the issues" → (Merged) created by apaderno
Pipeline finished with Success
5 months ago
Total: 172s
#80659
Issue was unassigned.
Comment 5 months ago →
🇨🇦Canada danrod
Status changed to Needs review 5 months ago4:12pm 22 January 2024
Comment 5 months ago →
🇨🇦Canada danrod
Comment 5 months ago →
🇨🇦Canada danrod
Comment 5 months ago →
🇨🇦Canada danrod
Status changed to Active 5 months ago9:22pm 23 January 2024
Comment 5 months ago →
🇨🇦Canada danrod
Assigned to Preethy_ray
Status changed to Needs work 5 months ago8:45am 24 January 2024
Comment 5 months ago →
🇮🇳India Preethy_ray
Comment 5 months ago →
🇮🇳India Preethy_ray
Pipeline finished with Success
5 months ago
#81749
Pipeline finished with Running
5 months ago
#82205
Issue was unassigned.
Status changed to Needs review 5 months ago5:41am 25 January 2024
Comment 5 months ago →
🇮🇳India Preethy_ray

Comment 5 months ago →

🇨🇦Canada danrod

I'm seeing an issue when trying to edit Calendar Events or Calendars:

TypeError: Drupal\google_calendar_service\Form\CalendarForm::__construct(): Argument #2 ($entity_type_manager) must be of type Drupal\Core\Entity\EntityTypeManagerInterface, Drupal\Core\Entity\EntityTypeBundleInfo given, called in /var/www/html/web/modules/contrib/google_calendar_service/src/Form/CalendarForm.php on line 84 in Drupal\google_calendar_service\Form\CalendarForm->__construct() (line 59 of /var/www/html/web/modules/contrib/google_calendar_service/src/Form/CalendarForm.php).

I'll push a change to fix this.

Status changed to Needs work 5 months ago11:00pm 29 January 2024
Comment 5 months ago →
🇨🇦Canada danrod
Comment 5 months ago →
🇨🇦Canada danrod
Status changed to Needs review 5 months ago11:12pm 29 January 2024

Comment 5 months ago →

🇨🇦Canada danrod

I ran phpcs again and I don't see any issues as well:

$ phpcs -v --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/google_calendar_service/
Registering sniffs in the Drupal standard... DONE (125 sniffs registered)
Creating file list... DONE (36 files in queue)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service
Processing google_calendar_service.links.menu.yml [PHP => 19 tokens in 19 lines]... DONE in 5ms (0 errors, 0 warnings)
Processing google_calendar_service.links.action.yml [PHP => 11 tokens in 11 lines]... DONE in 0ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/config/install
Processing views.view.gcs_calendar_events.yml [PHP => 1336 tokens in 1336 lines]... DONE in 8ms (0 errors, 0 warnings)
Processing google_calendar_service.default.yml [PHP => 2 tokens in 2 lines]... DONE in 0ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service
Processing README.md [PHP => 69 tokens in 69 lines]... DONE in 0ms (0 errors, 0 warnings)
Processing google_calendar_service.install [PHP => 190 tokens in 33 lines]... DONE in 4ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src
Processing CalendarListBuilder.php [PHP => 625 tokens in 87 lines]... DONE in 8ms (0 errors, 0 warnings)
Processing CalendarEventAccessControlHandler.php [PHP => 341 tokens in 70 lines]... DONE in 5ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Entity
Processing CalendarEventInterface.php [PHP => 451 tokens in 94 lines]... DONE in 5ms (0 errors, 0 warnings)
Processing CalendarEvent.php [PHP => 2410 tokens in 361 lines]... DONE in 32ms (0 errors, 0 warnings)
Processing CalendarViewsData.php [PHP => 89 tokens in 20 lines]... DONE in 1ms (0 errors, 0 warnings)
Processing Calendar.php [PHP => 1910 tokens in 301 lines]... DONE in 25ms (0 errors, 0 warnings)
Processing CalendarInterface.php [PHP => 509 tokens in 107 lines]... DONE in 6ms (0 errors, 0 warnings)
Processing CalendarEventViewsData.php [PHP => 89 tokens in 20 lines]... DONE in 1ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Plugin/Validation/Constraint
Processing TimeAvailableConstraintValidator.php [PHP => 745 tokens in 100 lines]... DONE in 10ms (0 errors, 0 warnings)
Processing TimeAvailableConstraint.php [PHP => 155 tokens in 33 lines]... DONE in 2ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Plugin/QueueWorker
Processing CalendarImportProcessor.php [PHP => 380 tokens in 70 lines]... DONE in 5ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src
Processing GoogleHttpClientFactory.php [PHP => 467 tokens in 82 lines]... DONE in 6ms (0 errors, 0 warnings)
Processing CalendarAccessControlHandler.php [PHP => 341 tokens in 70 lines]... DONE in 5ms (0 errors, 0 warnings)
Processing CalendarEventListBuilder.php [PHP => 379 tokens in 57 lines]... DONE in 5ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Form
Processing ImportEventsForm.php [PHP => 947 tokens in 163 lines]... DONE in 12ms (0 errors, 0 warnings)
Processing CalendarEventDeleteForm.php [PHP => 745 tokens in 121 lines]... DONE in 10ms (0 errors, 0 warnings)
Processing CalendarForm.php [PHP => 846 tokens in 141 lines]... DONE in 12ms (0 errors, 0 warnings)
Processing CalendarSettingsForm.php [PHP => 1852 tokens in 306 lines]... DONE in 25ms (0 errors, 0 warnings)
Processing CalendarEventForm.php [PHP => 1849 tokens in 271 lines]... DONE in 26ms (0 errors, 0 warnings)
Processing CalendarDeleteForm.php [PHP => 311 tokens in 51 lines]... DONE in 5ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src
Processing CalendarHtmlRouteProvider.php [PHP => 335 tokens in 53 lines]... DONE in 5ms (0 errors, 0 warnings)
Processing CalendarEditEvents.php [PHP => 1958 tokens in 297 lines]... DONE in 24ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src/Controller
Processing CalendarImportController.php [PHP => 883 tokens in 155 lines]... DONE in 12ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service/src
Processing CalendarImport.php [PHP => 2271 tokens in 345 lines]... DONE in 30ms (0 errors, 0 warnings)
Changing into directory /home/daniel/websites/drupal-components-library/web/modules/contrib/google_calendar_service
Processing google_calendar_service.services.yml [PHP => 16 tokens in 16 lines]... DONE in 0ms (0 errors, 0 warnings)
Processing google_calendar_service.module [PHP => 538 tokens in 84 lines]... DONE in 7ms (0 errors, 0 warnings)
Processing google_calendar_service.links.task.yml [PHP => 31 tokens in 31 lines]... DONE in 0ms (0 errors, 0 warnings)
Processing google_calendar_service.routing.yml [PHP => 44 tokens in 44 lines]... DONE in 0ms (0 errors, 0 warnings)
Processing google_calendar_service.info.yml [PHP => 9 tokens in 9 lines]... DONE in 3ms (0 errors, 0 warnings)
Processing google_calendar_service.permissions.yml [PHP => 31 tokens in 31 lines]... DONE in 0ms (0 errors, 0 warnings)
$

I changed the issue to "Needs Review" in case anyone wants to review my changes as well.

Comment 5 months ago →
System Message

danrod → committed 6bff2219 on 3.0.x authored by apaderno →
Resolve #3416145 "Fix the issues"
Comment 5 months ago →
🇨🇦Canada danrod
Merged to the 3.0.x branch, thanks a lot to everyone involved on this!
Status changed to RTBC 5 months ago1:33am 31 January 2024
Comment 5 months ago →
🇨🇦Canada danrod
Status changed to Fixed 5 months ago1:37am 31 January 2024
Comment 5 months ago →
🇨🇦Canada danrod
Comment 5 months ago →
System Message

danrod → committed 6bff2219 on 8.x-2.x authored by apaderno →
Resolve #3416145 "Fix the issues"
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Merge Requests

!12Fix the issues reported by phpcs
Merged

Comments & Activities

Fix the issues reported by phpcs

Merge Requests

!12Fix the issues reported by phpcsMerged

Comments & Activities

!12Fix the issues reported by phpcs
Merged