- Issue created by @finnsky
- First commit to issue fork.
- Status changed to Needs review
10 months ago 8:43am 19 January 2024 - 🇷🇺Russia kostyashupenko Omsk
I did the easiest available thing. Since expand side nav button is a part of top_bar template - i decided to keep the same logic.
- Status changed to Needs work
10 months ago 3:29am 20 January 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Small suggestions. See MR for threads. Nice work!
- Status changed to Needs review
10 months ago 10:49am 24 January 2024 - 🇷🇸Serbia finnsky
Removed that `not-needed` class
In favor of combination of::has https://caniuse.com/css-has
AND
:only-child https://caniuse.com/mdn-css_selectors_only-childAddressed feedbacks.
- Status changed to Needs work
10 months ago 3:55pm 30 January 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Looks like this needs to be rebased against the latest 1.x since 📌 Decouple from Toolbar module Needs review was merged. See also one additional comment on updating the permission that we use here.
- Status changed to Needs review
10 months ago 4:38pm 30 January 2024 - Status changed to RTBC
10 months ago 5:38pm 30 January 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Looks great! Thanks for the quick changes.
RTBC for me.
- Status changed to Fixed
10 months ago 2:28pm 31 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.