Fix the issues reported by phpcs

FILE: /app/web/modules/contrib/asset_injector/tests/src/Functional/AssetInjectorJsTest.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. 14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/tests/src/Functional/AssetInjectorCssTest.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait. 14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/src/AssetInjectorListBuilder.php ------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------ 108 | WARNING | Line exceeds 80 characters; contains 82 characters ------------------------------------------------------------------------------ FILE: /app/web/modules/contrib/asset_injector/src/Form/AssetInjectorJsDuplicateForm.php ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ----------------------------------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/src/Form/AssetInjectorDisableForm.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 5 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/src/Form/AssetInjectorFormBase.php ------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityForm. 219 | ERROR | [x] Use null coalesce operator instead of ternary operator. ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/src/Form/AssetInjectorDeleteForm.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 5 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements --------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/src/Form/AssetInjectorEnableForm.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 5 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/src/Form/AssetInjectorJsForm.php ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------- 11 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 106 | ERROR | [x] Use null coalesce operator instead of ternary operator. ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/src/Entity/AssetInjectorBase.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\asset_injector\AssetFileStorage. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/src/AssetInjectorAccessControlHandler.php --------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------- 164 | WARNING | Line exceeds 80 characters; contains 108 characters --------------------------------------------------------------------------------------- FILE: /app/web/modules/contrib/asset_injector/asset_injector.module ------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------ 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Asset\AttachedAssetsInterface. ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @pinesh
Comment about 1 year ago →
🇮🇳India pinesh
Status changed to Needs review about 1 year ago9:56am 17 January 2024
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
8 pass
Comment about 1 year ago →
🇮🇳India pinesh
Comment about 1 year ago →
🇺🇸United States pookmish
Status changed to RTBC about 1 year ago7:32am 18 January 2024

Comment about 1 year ago →

🇵🇭Philippines clarkssquared

I applied the patch #2 and I confimed that it fixes the PHPCS issues and errors

➜  asset_injector git:(8.x-2.19) curl https://www.drupal.org/files/issues/2024-01-17/3415217-1.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9250  100  9250    0     0  21212      0 --:--:-- --:--:-- --:--:-- 21461
patching file asset_injector.module
patching file 'js/asset_injector.js'
patching file 'src/AssetInjectorAccessControlHandler.php'
patching file 'src/AssetInjectorListBuilder.php'
patching file 'src/Entity/AssetInjectorBase.php'
patching file 'src/Form/AssetInjectorDeleteForm.php'
patching file 'src/Form/AssetInjectorDisableForm.php'
patching file 'src/Form/AssetInjectorEnableForm.php'
patching file 'src/Form/AssetInjectorFormBase.php'
patching file 'src/Form/AssetInjectorJsDuplicateForm.php'
patching file 'src/Form/AssetInjectorJsForm.php'
patching file 'tests/src/Functional/AssetInjectorCssTest.php'
patching file 'tests/src/Functional/AssetInjectorJsTest.php'
➜  asset_injector git:(8.x-2.19) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml asset_injector 
➜  contrib git:(master) ✗

Comment 10 months ago →
🇩🇪Germany Anybody Porta Westfalica
Could someone please provide these changes as MR? Would be a lot easier to review and comment on.
Status changed to Needs work 9 months ago8:32pm 5 July 2024
Comment 9 months ago →
🇺🇸United States pookmish
Patch does not apply due to change in the code. Please resubmit as a MR
Merge request !243415217-fix-the-issues:Fix the issues reported by phpcs → (Merged) created by pinesh
Status changed to Needs review 9 months ago7:39am 8 July 2024
Comment 9 months ago →
🇮🇳India pinesh
Comment 9 months ago →
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
#9 MR I have Applied and tested It Not Giving the any phpcs Error and Waring. From My Side RTBC +1.
Status changed to RTBC 9 months ago9:30am 8 July 2024
Comment 9 months ago →
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Status changed to Fixed 9 months ago5:28pm 8 July 2024
Comment 9 months ago →
🇺🇸United States pookmish
Comment 9 months ago →
🇮🇳India pinesh
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!24Fix the issues reported by phpcs
Merged

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!24Fix the issues reported by phpcsMerged

Comments & Activities

!24Fix the issues reported by phpcs
Merged