- Status changed to Needs work
8 months ago 3:20pm 17 January 2024 - π³π±Netherlands Lendude Amsterdam
Nice find, we need a test for this, I've already written one in π A number of Views combined fields filter operators are currently pointless to an end user Needs work that just hasn't landed yet.
Probably easiest to grab the REGEX test from that and add it here and see if it indeed fails on PostGreSQL
- Status changed to Needs review
8 months ago 9:53pm 17 January 2024 I've attached two patches, one with the REGEX test and one with both REGEX test + fix.
- last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - Status changed to Needs work
8 months ago 10:04pm 17 January 2024 The Needs Review Queue Bot β tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request β . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
I've attached two patches, one with the REGEX test and one with both REGEX test + fix.
- last update
8 months ago Build Successful - last update
8 months ago Build Successful - Status changed to Needs review
8 months ago 11:01pm 17 January 2024 - π³π±Netherlands Lendude Amsterdam
Nice, moved to a MR and lets see if the test run better there, works fine locally
- Status changed to RTBC
8 months ago 8:28am 18 January 2024 - π³π±Netherlands Lendude Amsterdam
PostgreSQL test-only fails as expected: https://git.drupalcode.org/issue/drupal-3415118/-/jobs/653536
So this looks good to me
- π³π±Netherlands daffie
The testbot for PostgreSQL is still failing. See: https://git.drupalcode.org/issue/drupal-3415118/-/jobs/653536
- π³π±Netherlands Lendude Amsterdam
@daffie the visual representation leaves a little to be desired to make it clear, but if you look at the top level Postgres build you can see that the normal test runs pass and only the test-only run fails, as we would hope
https://git.drupalcode.org/issue/drupal-3415118/-/pipelines/79102
- π³π±Netherlands daffie
if you look at the top level Postgres build you can see that the normal test runs pass and only the test-only run fails, as we would hope
I did not know we had a "tests only" run. That is really great!
@lendude: Thank you for the explanation! - π³πΏNew Zealand quietone New Zealand
@ahmad.k, Welcome to Drupal!
I'm triaging RTBC issues β . I read the IS and the comments. At first, this is a bit confusing because the standard template was not used and there is no statement of the problem. But all the information is there.
I read the MR and the test. It all appears it order. And it too a few clicks but I have confirmed that a test run on PostgreSQL.
Leaving at RTBC;
- π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed b3c74ca14e to 11.x and c42d624654 to 10.3.x and f0e32bb3f3 to 10.2.x. Thanks!
Backported to 10.2.x as a non-disruptive bug fix.
-
alexpott β
committed f0e32bb3 on 10.2.x
Issue #3415118 by ahmad.k, Lendude: Combine fields filter REGEXP causes...
-
alexpott β
committed f0e32bb3 on 10.2.x
-
alexpott β
committed c42d6246 on 10.3.x
Issue #3415118 by ahmad.k, Lendude: Combine fields filter REGEXP causes...
-
alexpott β
committed c42d6246 on 10.3.x
- Status changed to Fixed
6 months ago 9:18am 29 February 2024 -
alexpott β
committed b3c74ca1 on 11.x
Issue #3415118 by ahmad.k, Lendude: Combine fields filter REGEXP causes...
-
alexpott β
committed b3c74ca1 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.