Text visibility issue on node.

Created on 16 January 2024, 11 months ago
Updated 7 February 2024, 11 months ago

Problem/Motivation

Text visibility issue on node.

Steps to reproduce

  1. Install the theme set as an administration theme.
  2. Go to the /admin/appearance/settings/gin
  3. Go to theme settings and Appearance and enable the dark mode
  4. Create node by article/Basic page
  5. view that node which you created
  6. On top left side you see the "Edit node title"
  7. "Edit node title" text is not visible properly

For reference:

Proposed resolution

Text color should be white, to fix this issue use gin color variable.

    color: var(--gin-color-title);

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: duplicate

Version

3.0

Component

Code

Created by

🇮🇳India djsagar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @djsagar
  • Assigned to lalit-jangir
  • First commit to issue fork.
  • 🇮🇳India ahsannazir

    Can you please add more details to reproduce the issue. Its working fine for me

  • 🇮🇳India djsagar

    @ahsannazir please click on view tab to replicate the issue

    For reference:

  • Merge request !365gin-3414948-add-breadcrumb-styles → (Open) created by Unnamed author
  • Status changed to Needs review 11 months ago
  • 🇮🇳India ahsannazir

    The issue is occurring when we have Legacy toolbar selected in Gin settings. Raised a MR to fix the issue.

  • Status changed to RTBC 11 months ago
  • 🇮🇳India Sandeep_k New Delhi

    Hi @ahsannazir @djsagar, I've Tested the shared MR- MR !365 mergeable on the Drupal- 10.2.2-dev version, The Patch was applied successfully and looks good to me.

    Testing Steps:

    • Install the theme set as an administration theme.
    • Go to> admin/appearance/settings/gin> enable the dark mode & Select Legacy toolbar.
    • Create node by article/Basic page.
    • View the created node to reproduce this- Attached before the results.
    • Download the shared patch & apply.
    • Go to the content node again to re-verify this.

    Testing Results:
    After applying the patch, the text visibility issue is fixed now. RTBC++

  • Issue was unassigned.
  • Status changed to Closed: works as designed 11 months ago
  • 🇨🇭Switzerland saschaeggi Zurich

    We're not officially supporting using Gin as a frontend theme. To solve this you might need to use the correct breadcrumbs template from Gin.

  • Status changed to Needs review 11 months ago
  • 🇮🇳India djsagar

    HI @saschaeggi,

    It appears that this issue is only replicated when using Navigation (Legacy, Classic Drupal Toolbar), and the CSS for .gin-back-to-admin is not being applied in this scenario. However, when using other navigation options, the CSS is applied as expected.

    With Navigation (Legacy, Classic Drupal Toolbar)

    Without Navigation (Legacy, Classic Drupal Toolbar)

  • Status changed to Closed: duplicate 11 months ago
  • 🇨🇭Switzerland saschaeggi Zurich

    Closing as it's related to #[3419076]

  • Pipeline finished with Failed
    2 months ago
    #310268
  • Pipeline finished with Success
    2 months ago
    #310270
Production build 0.71.5 2024