- Issue created by @AstonVictor
- Status changed to Postponed
about 1 year ago 3:19pm 15 January 2024 - π¬π§United Kingdom adamps
Great thanks for your enthusiasm. We already have a stable release for Drupal 10. The module is now quite stable, but there are still a few issues open and it would be great to have help fixing them and you could post patches or merge requests.
After you have some specific experience with this module that we can talk about you becoming a co-maintainer. For sure you have an impressive profile on Drupal.org. The challenge for anyone joining the team is that this module contains some code that is very subtle and security-critical. Even though I've developed most of the code, sometimes I have to spend an hour checking all the details of a fixπ.
- Status changed to Needs work
about 1 year ago 8:32am 16 January 2024 - πΊπ¦Ukraine AstonVictor
thanks for your feedback
I've already worked on some issues:
https://www.drupal.org/project/manage_display/issues/3414907 π Call to static method fromRoute() on an unknown class Url. Needs review
https://www.drupal.org/project/manage_display/issues/3371841 π¬ LoaderError Template field--node--uid.html.twig Active
https://www.drupal.org/project/manage_display/issues/3402097 π Settings have no effect at all in Drupal 10 Closed: works as designedplease, review them
thanks - Status changed to Needs review
about 1 year ago 8:40am 16 January 2024 - π¬π§United Kingdom adamps
I took a quick look, great thanks, that's really helpful. I'll look in more detail later when I have more time.
- πΊπ¦Ukraine AstonVictor
FYI reviewed some more issues and provided feedback:
- https://www.drupal.org/project/manage_display/issues/3404403 π Error when using with feeds when viewing a feed entity Closed: duplicate
- https://www.drupal.org/project/manage_display/issues/3380114 β¨ CSS classes configuration form field Needs review
- https://www.drupal.org/project/manage_display/issues/3393480 π Title field link to content not working when html field format ius Closed: works as designed - πΊπ¦Ukraine AstonVictor
One more resolved issue - https://www.drupal.org/project/manage_display/issues/3416673 π The "comment" entity cannot have a URI Needs review
- π¬π§United Kingdom adamps
Great thanks I really appreciate your support and I would like to have you as a maintainer. I would still like to review the issues please as I think I can spot some extra things from my experience as author of the module. Would you be OK to work like that? You can set me to owner with "Needs review" status then I will set back to "RTBC" when I'm happy for you to commit. I will check roughly once per month. How does that sound??
- πΊπ¦Ukraine AstonVictor
It sounds good. I wonβt merge any issues until your review.
- Status changed to Fixed
about 1 year ago 4:03pm 3 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.