- Issue created by @andresgmh
- Status changed to Needs review
8 months ago 9:36pm 26 October 2023 - last update
8 months ago 2 pass - Status changed to RTBC
8 months ago 3:30pm 31 October 2023 - Status changed to Needs work
6 months ago 10:52pm 7 December 2023 - πΊπΈUnited States joegraduate Arizona, USA
A couple of nitpicks with patch #2:
-
+++ b/config/schema/manage_display.schema.yml @@ -4,6 +4,9 @@ field.formatter.settings.title: + tag_css_classes:
I don't think this new setting name needs the
tag_
prefix. -
+++ b/src/Plugin/Field/FieldFormatter/TitleFormatter.php @@ -70,7 +79,8 @@ class TitleFormatter extends StringFormatter { + $item['#prefix'] = ($tag_css_classes !== '') ? "<$tag class='$tag_css_classes'>" : "<$tag>";
Would probably be better to use
!empty()
here.
-
- Status changed to Needs review
6 months ago 11:01pm 7 December 2023 - last update
6 months ago 2 pass - πΊπΈUnited States joegraduate Arizona, USA
Updated patch that addresses items in #6.
- First commit to issue fork.
- last update
5 months ago 2 pass - πΊπ¦Ukraine AstonVictor
Created a new MR.
Added changes as a mr and updated the
settingsSummary()
method in order not to show the summary for classes if the field is empty. - π¬π§United Kingdom AdamPS
Thanks for the contributions. For sure I can see that some sites would wish for this feature I even have a feeling that someone requested it before although I can't find the issue now.
This module aims to get the formatters added to Drupal Core. When developing the formatters I aimed to copy the Core formatters as closely as possible. Core mostly doesn't add a lot of extra configuration options, so I expect they wouldn't accept the option in this feature request. Hence it seems like we shouldn't add it here. What does anyone else think?
Perhaps can use this https://www.drupal.org/project/field_formatter_class β ?
- Status changed to Postponed: needs info
5 months ago 7:58am 22 January 2024