- Issue created by @promo-il
- Status changed to Needs work
10 months ago 10:49am 19 September 2024 - π©πͺGermany Anybody Porta Westfalica
@Promo-IL could you prepare this as MR please?
- First commit to issue fork.
- π΅π±Poland dlevchik Poznan, Poland
dlevchik β changed the visibility of the branch 3414174-add-bypass-ad to hidden.
- π΅π±Poland dlevchik Poznan, Poland
dlevchik β changed the visibility of the branch 3414174-add-bypass-ad to active.
- Merge request !4Issue #3414174 by promo-il: Add "Bypass ad tracking" permission β (Closed) created by dlevchik
- π΅π±Poland dlevchik Poznan, Poland
Created MR porting a patch to 10.x, also changing it a little by moving permission check to trackEvent()
- Assigned to lrwebks
- π©πͺGermany lrwebks Porta Westfalica
Question (mainly directed at @anybody): π Integrate ad content type level permissions using "permission_callbacks" and "AccessControlHandler" Active will introduce a new permission called βView adsβ. Only roles with that permission will see ads on the live site. Would this solve this issue? Or is a separate βBypass ad trackingβ permission sill necessary? I personally don't know why someone would want ads shown to them, but not being tracked, but what do I know.
- π©πͺGermany Anybody Porta Westfalica
Add "Bypass ad tracking" permission is still relevant, because certain roles should not be tracked. But I think it should be fairly simple. At the place where the counter is counting, simply skip counting with this permission. Everything else stays the same.
- π©πͺGermany lrwebks Porta Westfalica
lrwebks β changed the visibility of the branch 4.0.x to hidden.
- π©πͺGermany lrwebks Porta Westfalica
lrwebks β changed the visibility of the branch 11.x to hidden.
- π©πͺGermany lrwebks Porta Westfalica
Everything should be operational now in !12. Unfortunately, click tracking is currently not working either way, even on 11.x, see π Click tracking doesn't work anymore Active .
- π©πͺGermany lrwebks Porta Westfalica
Re #18: Click tracking does work, so everything is working here. Click tracking is also not tracked for users with the bypass permission.
-
anybody β
committed a7c621ec on 11.x authored by
lrwebks β
Issue #3414174 by lrwebks, anybody: Add "Bypass ad tracking" permission
-
anybody β
committed a7c621ec on 11.x authored by
lrwebks β
Automatically closed - issue fixed for 2 weeks with no activity.