- Issue created by @quietone
- Status changed to Needs review
12 months ago 5:10am 12 January 2024 - 🇮🇳India adwivedi008
Replaced the enable to install
core/modules/language/language.module:
$additional_overview = t("If the Interface Translation module is enabled, this page will provide an overview of how much of the site's interface has been translated for each configured language."); $additional_continue = t('Depending on your site features, additional modules that you might want to enable are:') . '<ul>';
while the second one is already resolved.
core/modules/system/system.install:'description' => t('The current database driver is provided by the module: %module. The module is currently not enabled. You should immediately <a href=":enable">enable</a> the module.', ['%module' => $provider, ':enable' => Url::fromRoute('system.modules_list')->toString()]),
Please review if any other changes needed, moving the ticket to needs review.
- Status changed to Needs work
11 months ago 2:31pm 12 January 2024 - 🇺🇸United States smustgrave
Can you please convert to an MR, patches are being phased out.
- First commit to issue fork.
- Merge request !6168issues-3414165-used-installed-instead-of-enabled → (Closed) created by shalini_jha
- Status changed to Needs review
11 months ago 10:32am 15 January 2024 - Status changed to Needs work
11 months ago 10:45am 15 January 2024 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
11 months ago 8:52am 16 January 2024 - Status changed to RTBC
11 months ago 2:52pm 16 January 2024 - Status changed to Needs work
11 months ago 6:09pm 3 February 2024 - 🇬🇧United Kingdom longwave UK
More strings that can be changed here:
core/lib/Drupal/Core/Block/Plugin/Block/Broken.php: '#markup' => $this->t('This block is broken or missing. You may be missing content or you might need to enable the original module.'), core/lib/Drupal/Core/Installer/Exception/NoProfilesException.php: $message = $this->t('We were unable to find any installation profiles. Installation profiles tell us what modules to enable and what schema to install in the database. A profile is necessary to continue with the installation process.'); core/modules/editor/editor.module: $form['editor']['editor']['#description'] = t('This option is disabled because no modules that provide a text editor are currently enabled.'); core/modules/filter/help_topics/filter.overview.html.twig:<p>{% trans %}Text fields that have "formatted" in the field type name, such as <em>Text (formatted)</em>, use text formats. Users choose the text format when editing the field text; when the field text is shown on the site, it is processed by the chosen text format. Administrators can configure text formats and assign permissions for who can use each format. If the core Text Editor module is enabled, administrators can also associate visual editors with text formats.{% endtrans %}</p> core/modules/language/language.module: $additional_continue = t('Depending on your site features, additional modules that you might want to enable are:') . '<ul>'; core/modules/migrate_drupal_ui/migrate_drupal_ui.install: \Drupal::messenger()->addStatus(t('The Migrate Drupal UI module has been enabled. Proceed to the <a href=":url">upgrade form</a>.', [':url' => $url])); core/modules/system/system.admin.inc: $current_theme['incompatible'] = t('This theme requires the listed modules to operate correctly. They must first be enabled by a user with permissions to do so.'); core/modules/system/system.admin.inc: $current_theme['incompatible'] = t('This theme requires the listed modules to operate correctly. They must first be enabled via the <a href=":modules_url">Extend page</a>.', [ core/modules/system/system.links.menu.yml: description: 'Add and enable modules to extend site functionality.' core/modules/update/update.api.php: 'description' => 'A module not enabled on the site that you want to see in the available updates report.',
Unsure about this last one, whether we leave references to D6/7 as "enabled" because that was the terminology back then?
core/modules/migrate_drupal/src/Plugin/migrate/source/DrupalSqlBase.php: throw new RequirementsException('The module ' . $source_module . ' is not enabled in the source site.', ['source_module' => $source_module]);
- 🇳🇿New Zealand quietone
Yes, there are still many more instances to change. I scoped this one to the two instances found in other issues and that allowed this to be tagged 'Novice'. But I see that is also not aligned with the issue title. I've changed the proposed resolution.
I am going to work on this for a while right now.
- Status changed to Needs review
11 months ago 8:37am 4 February 2024 - 🇳🇿New Zealand quietone
I used PHPStorm for searching and reviewed all the usages in strings and fixed the relevant ones.
- 🇳🇿New Zealand danielveza Brisbane, AU
The code itself looks good, do we need a IS update before we can move this to RTBC since this is doing more than 2 strings now?
- Status changed to Needs work
10 months ago 9:56am 11 February 2024 - Status changed to Needs review
10 months ago 8:22am 12 February 2024 - 🇳🇿New Zealand quietone
I have already updated the proposed resolution with the wider scope. I have now updated the 'Problem/Motivation' section.
- Status changed to RTBC
10 months ago 3:53pm 15 February 2024 - 🇺🇸United States smustgrave
Seems to have gotten a few reviews. Issue summary appears to be completed in last comment
Going to mark.
-
longwave →
committed 865b8f43 on 11.x
Issue #3414165 by quietone, shalini_jha, adwivedi008, longwave: Use "...
-
longwave →
committed 865b8f43 on 11.x
- Status changed to Fixed
10 months ago 4:47pm 15 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.