- Issue created by @pdureau
- Assigned to Christian.wiedemann
- Status changed to Postponed
6 months ago 8:19am 17 May 2024 - π«π·France pdureau Paris
Maybe we will remove _template all together.
Let's wait and discuss.If we remove this property, don't forget to:
- Revert this change : π [2.0.0-alpha2] Wrong template name leads to Deprecated: basename(): Passing null to parameter #1 ($path) Fixed
- Update the specification
- Close the SDC issue: β¨ Allow declaration of template path in SDC Active
- Status changed to Needs work
4 months ago 4:52pm 4 July 2024 - π©πͺGermany Christian.wiedemann
Christian.wiedemann β made their first commit to this issueβs fork.
- Status changed to Needs review
4 months ago 10:26pm 12 July 2024 - π©πͺGermany Christian.wiedemann
I used component_definition_alter instead of component_info for the hook name. Thought it is more straight forward.
- π«π·France pdureau Paris
Indeed, you did:
$this->moduleHandler->alter('component_definition', $definition);
Instead of:
$this->alterInfo('component_info');
Doing that, we are diverging from the comment in the SDC codebase, I hope we will not have a concurrent implementation if SDC implements the alter hook later.
- Issue was unassigned.
- π«π·France mogtofu33
I think IMHO that we should keep 'component_info', so if the core sdc enable this alter, we'll know we have to remove it, and there will be break on existing code.
- Assigned to Christian.wiedemann
- Status changed to Needs work
4 months ago 11:14am 19 July 2024 - π©πͺGermany Christian.wiedemann
Or ui_patterns_component_definition. For me component_info is altering the plugin not the plugin definition.
- Status changed to Needs review
4 months ago 8:14pm 22 July 2024 -
pdureau β
committed bb17c778 on 2.0.x authored by
Christian.wiedemann β
Issue #3413589 by Christian.wiedemann: Add alterInfo('component_info')...
-
pdureau β
committed bb17c778 on 2.0.x authored by
Christian.wiedemann β
- Issue was unassigned.
- Status changed to Fixed
4 months ago 8:28pm 22 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.