- Issue created by @Christian.wiedemann
- 🇫🇷France pdureau Paris
The specific template file naming of button & progress components are testing a specific feature.
There is already a template property in component definition, but SDC ComponentPluginManager is always overriding its value.
We need to keep this property value if already set in YAML, so templates can be loaded from external codebase.
This replaces the “use” property in UI Patterns 1.x.
The value supports Twig namespaces.https://docs.google.com/document/d/1-GaMK1Qk-h0hmB7GtAcnqPTuCOGMaxeRguop...
So, we have 2 solutions:
- a patch for upstream SDC, which is wrong to not test the value of $template before doing a basename()
- the solution you have proposed here
- Assigned to oldeb
- Merge request !86#3440441 Overriding SDC's alterDefinition method to fix empty $template issue → (Merged) created by oldeb
- Status changed to Needs review
8 months ago 3:09pm 25 April 2024 - 🇩🇪Germany Christian.wiedemann
I think we can move the code from alterDefinitions to alterDefinition and remove alterDefinitions.
- Issue was unassigned.
- Status changed to Fixed
7 months ago 8:59am 10 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.