Get PHPStan level 1 passing and enable automated test job

All issues have been resolved except for two which I felt were best ignored for now.

Thanks for the MR, I provide a feedback. Please check.

I rebased and resolved merge conflicts caused by 📌 Fix the issues reported by phpcs Needs work .

I made some changes to MigrationHelper in order to keep phpcs happy.

I am going to provide a BC layer, following Drupal deprecation policy > Constructor parameter additions → .

The MR is ready for review.

There are one or two open threads on the MR, but I think the intention is to open follow-up issues for them, As far as I am concerned, we do not need any more code changes for this issue.

Almost there, thanks! Resolved a few MR threads, but opened a couple more.

Applied a few of my own suggestions 😅, responded to and resolved all threads.

I think this is RTBC now, but maybe I'll let someone else say so and I can then commit it. 😉

Cheers,
-Derek

@dww:

Congratulations on/thanks for joining as a co-maintainer of this module! I have a client who would like to see a stable release, so you can ping me in Slack if there is a task you would like me to do on the way there.

I reviewed the two commits that you added, and I updated the change record https://www.drupal.org/node/3417929 → to match. LGTM

I am in the same boat as you: I have not stuck to the reviewer role on this issue. But if we are allowed to review each other's work, then I think we can (jointly) declare this issue to be RTBC.

I've reviewed the recent changes that have been made. They look good to me too. Thank you both for the help. RTBC+1.

oops

In #3413233-8: Drop PHP7 support to help with code cleanup → , I pointed out that there is another constructor update (from ✨ Allow themes to alter inline entity forms Fixed ) that should have a BC layer. Since we already handle something similar for the MigrationHelper class in this issue, we might want to fix that here.