- First commit to issue fork.
- Status changed to Fixed
over 1 year ago 9:27am 11 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Needs review
about 1 year ago 7:22pm 10 December 2023 - Status changed to RTBC
12 months ago 10:10pm 7 January 2024 - π©πͺGermany geek-merlin Freiburg, Germany
Review:
- Regression risk? Very low, so can be committed without tests.
- Why do some hooks also dispatch to themes, why others not?
-hook_views_ui_display_tab_alter
has a good explanation:// In AJAX context, ViewUI::rebuildCurrentTab() returns this outside of form // context, so hook_form_view_edit_form_alter() is insufficient. // @todo remove this after // https://www.drupal.org/project/drupal/issues/3087455 has been resolved. $this->moduleHandler->alter('views_ui_display_tab', $build, $view, $display_id); // Because themes can implement hook_form_FORM_ID_alter() and because this // is a workaround for hook_form_view_edit_form_alter() being insufficient, // also invoke this on themes. // @todo remove this after // https://www.drupal.org/project/drupal/issues/3087455 has been resolved. $this->themeManager->alter('views_ui_display_tab', $build, $view, $display_id);
- Does this need an update in ief.api-php?
- Yes, will do that on commit. - π©πͺGermany geek-merlin Freiburg, Germany
Also added a Change record for the new constructor argument, just to be sure:
https://www.drupal.org/node/3413055 β -
geek-merlin β
committed f8d53391 on 3.x
Issue #3224955 by rp7, geek-merlin: Allow themes to alter inline entity...
-
geek-merlin β
committed f8d53391 on 3.x
- Status changed to Fixed
12 months ago 10:28pm 7 January 2024 - πΊπΈUnited States dww
So you're still adding new features to the 3.x branch, and therefore the 3.0.x series? I thought part of the problem with the 2.0.x branch is that it was ignoring semver. 3.0.x should really be only bug fixes and tasks at this point. We probably need a 3.0.x branch now, so we can backport stable-only changes there, and leave 3.x as "main", for new features towards the 3.1.x series.
- π©πͺGermany geek-merlin Freiburg, Germany
@dww: The problem with 2.x was missing QA making thousands to test rabbits. Not semver.
Having said that, i'm split what the best semver policy is for the future. For now imho it's RC still.
But as i said in the stable release issue, RC18 may be the last.Opened π± Maintenance policy Active .
Automatically closed - issue fixed for 2 weeks with no activity.