Fix the issues reported by phpcs

    * @param \Drupal\Core\Form\FormStateInterface $form_state
    *   The current state of the form.
-   * 
+   *
    * @return Drupal\Core\Entity\EntityInterface\null
+   *   The entity handler.

Since that comment is changed, also @return Drupal\Core\Entity\EntityInterface\null. I take that should be @return Drupal\Core\Entity\EntityInterface|null.
The description is not correct: What reported is an entity, not an entity handler. It should also describe when NULL is returned.

   /**
+   * Retrieves the labels for the entity type.
+   *
    * @return array|\Drupal\Core\Entity\EntityTypeInterface
+   *   Array containing the singular and plural labels
    */

What returned is not just an array. The description does not say when a \Drupal\Core\Entity\EntityTypeInterface instance is returned.

-          \Drupal::moduleHandler()->invokeAll('inline_entity_form_entity_save', [&$form_state, $entity, $is_new]);
+          \Drupal::moduleHandler()->invokeAll('inline_entity_form_entity_save',
+          [&$form_state, $entity, $is_new]);

The last line must be indented.
I would rather leave the code as it is, since code lines are allowed to exceed 80 characters.

Will update the patch soon.

Updated the patch with suggested changes, please review.

#4 is in
tnx

Automatically closed - issue fixed for 2 weeks with no activity.

Bulk reopen.

Solved the all Phpcs error coming from 3.x version.
i use the cmd to show the error is : - ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/inline_entity_form
attached the patch file plz review ..

I was able to apply patch.

+++ b/src/Plugin/Field/FieldWidget/InlineEntityFormBase.php
@@ -73,13 +80,16 @@ abstract class InlineEntityFormBase extends WidgetBase implements ContainerFacto
+  public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, array $third_party_settings, EntityTypeBundleInfoInterface $entity_type_bundle_info, EntityTypeManagerInterface $entity_type_manager, EntityDisplayRepositoryInterface $entity_display_repository, ContentTranslationManagerInterface $content_translation_manager) {

Module hasn't dependency on content_translation module.
I think it's impossible to use it in method params if module is disabled.

+++ b/src/Plugin/Field/FieldWidget/InlineEntityFormBase.php
@@ -19,6 +20,12 @@ use Symfony\Component\DependencyInjection\ContainerInterface;
+  protected $contentTranslationManager;

Please add empty line below.

Since the branch has been changed, the issue summary probably needs to be updated. It is probable PHP_CodeSniffer's report will have different warnings/errors.

https://www.drupal.org/project/inline_entity_form/issues/3135178#comment... →

I think we are not going to fix \Drupal call with DI in InlineEntityFormBase.php
Reasons is the same as it was at comment → .
I mute phpcs for this violation.

I create MR from patch #9 with small changes.
Please make a review.

@apaderno thanks a lot for your feedback.
I provide my response, can you please provide more arguments?

Anjali Mehta → made their first commit to this issue’s fork.

Unresolved review notes, so NW.

Fix all violations, revert back to sprintf(). Ready for review.

Just a heads-up: This patch and the PHPStan issue are modifying the same lines in InlineEntityFormBase. One of the MRs will have to be rebased manually after the other gets committed.

> Ready for review.
I have no time currently. But there are unresolved notes still.

But there are unresolved notes still.

I double checked issue and MR, and I was not able to find unresolved notes.
I was not able to rebase MR with giltab UI, I made rebase manually.

I made change to MR, because module migration_plus is not obligatory.

I've reviewed the changes in the MR. They all look good to me. I agree that silencing the one "violation" about migrate_plus and using the fully namespaced class is a good choice (the only unresolved MR thread). The phpcs job is passing in the MR pipeline, e.g.: https://git.drupalcode.org/issue/inline_entity_form-3362087/-/jobs/608770

It'd be nice to merge this ASAP so that we can start relying on the GitLab CI pipelines to ensure that new changes don't introduce phpcs regressions.

RTBC!

Thanks,
-Derek

Thx Derek for the review!

Automatically closed - issue fixed for 2 weeks with no activity.