Decouple 'Help' link from the footer region, allow to be configured via Navigation admin UI

Created on 3 January 2024, 6 months ago
Updated 17 January 2024, 5 months ago

Problem/Motivation

In ๐Ÿ“Œ Create an administration UI for managing Navigation Sections Needs work we added the ability for the user to manage the navigation sections/components/blocks. However, the help link is hardcoded into the footer region. Users should have an option to move the help link amongst the navigation sections/components/blocks in the content region of the navigation bar.

Proposed resolution

The help link, which has already been taken out of main nav, and is in footer of the Navigation bar now, should be decoupled from the footer region and made into a navigation section/component/block that can be placed into the content region and removed from the footer region via the Navigation admin UI.

Remaining tasks

Discuss current placement in the "Content" area vs designs, considering that we don't allow the "Footer" area of the navigation bar to be managed anymore. Discussion will take place in weekly sync.

User interface changes

Navigation admin UI updates to allow for the Help link to be placed in the content region of the Navigation bar.

๐Ÿ“Œ Task
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

๐Ÿ‡จ๐Ÿ‡ฆCanada m4olivei Grimsby, ON

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @m4olivei
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Prashant.c Dharamshala

    Prashant.c โ†’ made their first commit to this issueโ€™s fork.

  • Merge request !2Decouple help link โ†’ (Open) created by Prashant.c
  • Status changed to Needs review 6 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Prashant.c Dharamshala

    Used the same pattern which is used to develop other components/sections to decouple the "Help" link from the footer. Here is the MR https://git.drupalcode.org/issue/navigation-3411099/-/merge_requests/2.

    Kindly review, thanks.

  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada m4olivei Grimsby, ON

    @Prashant.c could you rebase against 1.x and open a new MR against 1.x of the navigation repo? Thanks.

  • First commit to issue fork.
  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡ท๐Ÿ‡บRussia kostyashupenko Omsk

    Here is a new MR https://git.drupalcode.org/project/navigation/-/merge_requests/161
    which contains manual cherry-pick of #2
    + some other fixes, now ready for code-review

  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada m4olivei Grimsby, ON

    A few minor comments.

    We have this on the agenda to discuss this Wed. The original thought here was it would continue to live in the "Footer" area of the nav bar and users would have the option to put it into the "Content" area. However, since ๐Ÿ“Œ Restrict configuration of the Navigation bar footer items Fixed got in, we don't allow the "Footer" area to be managed in the UI.

    This MR puts the help link into the "Content" area, which makes sense to allow the user to manage it, but is a change that we should be on the same page about.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Akhil Babu Chengannur

    Akhil Babu โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Akhil Babu Chengannur

    I've added the changes as per the comments in #8. Please review

  • Status changed to Postponed 5 months ago
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada m4olivei Grimsby, ON

    Changes look great! Thanks @Akhil Babu.

    As noted in my last comment, this one will be up for discussion at our meeting tomorrow (see #admin-ui in Drupal Slack for details). Will mark as Postponed for now.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dead_arm

    I think that the Help link is an informational piece of the Drupal system and does not need to be configured via Navigation admin UI like the other links. It is important for this type of system-functional link to be in a consistent place, where users expect to find it.

  • Status changed to Closed: won't fix 5 months ago
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada m4olivei Grimsby, ON

    Thanks @dead_arm. As we want to have it be a static placement, will close the issue as Won't Fix since that's already the present behavior.

    Thanks for the efforts here everyone.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada m4olivei Grimsby, ON
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    As mentioned in Slack and the call and to be sure the decision gets reflected and traceable in the future, commenting here. Separating the Help link from the rest of the Administration menu is actually one of the first things we clearly saw on the first design iterations without needing to do research for that. Its priority on an Information Architecture is in another scale from the Administration menu, independently on why historically it ended up in that menu. So its placement shouldn't be linked to the admin menu. Also, because of it's purpose, its place is supposed to be always accessible and reachable, but always in the same place if you are logged in (so you get the Navigation toolbar).

    That said, and as discussed on today's meeting, we'll need to find the proper way to detach the existing Help link on the Navigation menu to place it into the footer.

  • Pipeline finished with Success
    3 months ago
    Total: 51s
    #125339
  • Pipeline finished with Success
    3 months ago
    Total: 84s
    #125963
  • Pipeline finished with Success
    3 months ago
    Total: 52s
    #126019
  • Pipeline finished with Success
    3 months ago
    Total: 299s
    #126021
  • Pipeline finished with Success
    2 months ago
    Total: 60s
    #140719
  • Pipeline finished with Success
    2 months ago
    Total: 386s
    #140712
  • Pipeline finished with Success
    about 2 months ago
    Total: 862s
    #152777
  • Pipeline finished with Success
    8 days ago
    Total: 166s
    #196113
  • Pipeline finished with Failed
    7 days ago
    Total: 1299s
    #196654
  • Pipeline finished with Success
    7 days ago
    Total: 1236s
    #196664
Production build 0.69.0 2024