- Issue created by @m4olivei
- ๐ฎ๐ณIndia prashant.c Dharamshala
Prashant.c โ made their first commit to this issueโs fork.
- Status changed to Needs review
9 months ago 12:07pm 5 January 2024 - ๐ฎ๐ณIndia prashant.c Dharamshala
Used the same pattern which is used to develop other components/sections to decouple the "Help" link from the footer. Here is the MR https://git.drupalcode.org/issue/navigation-3411099/-/merge_requests/2.
Kindly review, thanks.
- Status changed to Needs work
9 months ago 5:09pm 12 January 2024 - ๐จ๐ฆCanada m4olivei Grimsby, ON
@Prashant.c could you rebase against 1.x and open a new MR against 1.x of the navigation repo? Thanks.
- First commit to issue fork.
- Status changed to Needs review
9 months ago 5:54am 15 January 2024 - ๐ท๐บRussia kostyashupenko Omsk
Here is a new MR https://git.drupalcode.org/project/navigation/-/merge_requests/161
which contains manual cherry-pick of #2
+ some other fixes, now ready for code-review - Status changed to Needs work
9 months ago 4:08pm 15 January 2024 - ๐จ๐ฆCanada m4olivei Grimsby, ON
A few minor comments.
We have this on the agenda to discuss this Wed. The original thought here was it would continue to live in the "Footer" area of the nav bar and users would have the option to put it into the "Content" area. However, since ๐ Restrict configuration of the Navigation bar footer items Fixed got in, we don't allow the "Footer" area to be managed in the UI.
This MR puts the help link into the "Content" area, which makes sense to allow the user to manage it, but is a change that we should be on the same page about.
- ๐ฎ๐ณIndia Akhil Babu Chengannur
Akhil Babu โ made their first commit to this issueโs fork.
- Status changed to Needs review
9 months ago 11:08am 16 January 2024 - ๐ฎ๐ณIndia Akhil Babu Chengannur
I've added the changes as per the comments in #8. Please review
- Status changed to Postponed
9 months ago 4:44pm 16 January 2024 - ๐จ๐ฆCanada m4olivei Grimsby, ON
Changes look great! Thanks @Akhil Babu.
As noted in my last comment, this one will be up for discussion at our meeting tomorrow (see #admin-ui in Drupal Slack for details). Will mark as Postponed for now.
- ๐บ๐ธUnited States dead_arm
I think that the Help link is an informational piece of the Drupal system and does not need to be configured via Navigation admin UI like the other links. It is important for this type of system-functional link to be in a consistent place, where users expect to find it.
- Status changed to Closed: won't fix
8 months ago 4:08pm 17 January 2024 - ๐จ๐ฆCanada m4olivei Grimsby, ON
Thanks @dead_arm. As we want to have it be a static placement, will close the issue as Won't Fix since that's already the present behavior.
Thanks for the efforts here everyone.
- ๐ช๐ธSpain ckrina Barcelona
As mentioned in Slack and the call and to be sure the decision gets reflected and traceable in the future, commenting here. Separating the Help link from the rest of the Administration menu is actually one of the first things we clearly saw on the first design iterations without needing to do research for that. Its priority on an Information Architecture is in another scale from the Administration menu, independently on why historically it ended up in that menu. So its placement shouldn't be linked to the admin menu. Also, because of it's purpose, its place is supposed to be always accessible and reachable, but always in the same place if you are logged in (so you get the Navigation toolbar).
That said, and as discussed on today's meeting, we'll need to find the proper way to detach the existing Help link on the Navigation menu to place it into the footer.