- Issue created by @m4olivei
- 🇮🇳India prashant.c Dharamshala
Prashant.c → made their first commit to this issue’s fork.
- Merge request !1Restricted the configuration to content region only → (Closed) created by prashant.c
- 🇮🇳India prashant.c Dharamshala
Raised MR https://git.drupalcode.org/issue/navigation-3411099/-/merge_requests/1 and created the merge request against the https://git.drupalcode.org/issue/navigation-3411099/-/tree/3411099-creat....
Kindly review.
- Status changed to Needs review
12 months ago 7:37am 4 January 2024 - Status changed to Needs work
12 months ago 2:21pm 4 January 2024 - 🇨🇦Canada m4olivei Grimsby, ON
Thanks @Prashant.c. Couple things.
1. Lets hide the region column on the Navigation section UI, since there is only once choice. Probably change the form element to a
'#type' => 'value'
.2. Other note I left as a MR comment wrt the entity form.
- 🇮🇳India prashant.c Dharamshala
@m4olivei
As soon as Iam changing the form element from "select" to "value" or something else the tabledrag stops working, not able to drop items and JS error
The navigation section cannot be placed in this region.
Any ideas?
- 🇨🇦Canada m4olivei Grimsby, ON
Nothing immediately comes to mind, I would have to play with it. May get time for that next week. No rush, would like to see 📌 Create an administration UI for managing Navigation Sections Needs work land first anyway.
- 🇮🇳India prashant.c Dharamshala
I'm thinking whether it's okay to use CSS here to hide the label and select list for regions.
- Status changed to Needs review
12 months ago 2:48pm 9 January 2024 - 🇨🇦Canada m4olivei Grimsby, ON
I'm thinking whether it's okay to use CSS here to hide the label and select list for regions.
I don't think that's a great idea, you still have the form value you need to deal with on the back end.
I've pushed a couple of commits. First to remove the region column from the Navigation Section admin UI. That comes with necessary adjustments to the #tabledrag config and Javascript handling that we no longer need. Second, to change the #type select to #type value on the NavigationSectionForm.
I believe that puts us in a good place here. @Prashant.c, please review.
As we discussed in Slack, we will hold off on merge here until the main issue ( 📌 Create an administration UI for managing Navigation Sections Needs work ) is resolved and merged to 1.x.
- 🇨🇦Canada m4olivei Grimsby, ON
I needed to rebase the branch against
1.x
of thenavigation
module. I also needed to open a new MR (linked in the ticket description) b/c Gitlab wouldn't let me det the target fork for the MR that @Prashant.c opened. I've closed that one.@Prashant.c if you could review, that would be wonderful!
- 🇨🇦Canada m4olivei Grimsby, ON
m4olivei → changed the visibility of the branch 3412119-restrict-configuration-of to hidden.
- 🇨🇦Canada m4olivei Grimsby, ON
m4olivei → changed the visibility of the branch 3412119-restrict-configuration-of to active.
-
ckrina →
committed 057bfdce on 1.x authored by
m4olivei →
Resolve #3412119 "Restrict configuration of"
-
ckrina →
committed 057bfdce on 1.x authored by
m4olivei →
- Status changed to Fixed
11 months ago 3:17pm 15 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.