Contrib.social

Fix phpcs Drupal.Files.LineLength issues

Open on Drupal.org →
Created on 1 January 2024, over 1 year ago
Updated 16 July 2024, 9 months ago

Problem/Motivation

Fix phpcs errors for

  • Drupal.Files.LineLength

Command:

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig modules/custom/pathauto/ --sniffs="Drupal.Files.LineLength"

Result:


FILE: tests/src/Functional/PathautoNodeWebTest.php
----------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------
 208 | WARNING | Line exceeds 80 characters; contains 92 characters
     |         | (Drupal.Files.LineLength.TooLong)
 225 | WARNING | Line exceeds 80 characters; contains 81 characters
     |         | (Drupal.Files.LineLength.TooLong)
----------------------------------------------


FILE: tests/src/Kernel/PathautoTokenTest.php
---------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------
 38 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)
---------------------------------------------


FILE: tests/src/FunctionalJavascript/PathautoUiTest.php
----------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------
 107 | WARNING | Line exceeds 80 characters; contains 97 characters
     |         | (Drupal.Files.LineLength.TooLong)
----------------------------------------------


FILE: pathauto.module
---------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------
 16 | WARNING | Line exceeds 80 characters; contains 88 characters
    |         | (Drupal.Files.LineLength.TooLong)
---------------------------------------------


FILE: src/AliasUniquifier.php
----------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------
 105 | WARNING | Line exceeds 80 characters; contains 81 characters
     |         | (Drupal.Files.LineLength.TooLong)
----------------------------------------------


FILE: src/PathautoWidget.php
----------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------
 35 | WARNING | Line exceeds 80 characters; contains 149 characters
    |         | (Drupal.Files.LineLength.TooLong)
----------------------------------------------


FILE: src/AliasCleanerInterface.php
---------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------
 16 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)
 55 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)
---------------------------------------------


FILE: src/AliasUniquifierInterface.php
---------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------
 13 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)
---------------------------------------------

Time: 1.13 secs; Memory: 8MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇷🇺Russia zniki.ru

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @zniki.ru
  • Merge request !66Issue #3411807: Fix phpcs Drupal.Files.LineLength issues → (Open) created by zniki.ru
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    48 pass
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇷🇺Russia zniki.ru

    MR is ready for review:

    MR doesn't include fix for

    FILE: src/PathautoWidget.php
----------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------
 35 | WARNING | Line exceeds 80 characters; contains 149 characters (Drupal.Files.LineLength.TooLong)
----------------------------------------------

    this fixed in issue 📌 Fix phpcs Drupal.WhiteSpace, Squiz.WhiteSpace issues Needs review .

  • Pipeline finished with Failed
    over 1 year ago
    Total: 356s
    #70417
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    48 pass
  • Pipeline finished with Failed
    over 1 year ago
    Total: 371s
    #70425
  • Comment over 1 year ago →
    🇮🇳India sidharth_soman Bangalore

    Probably should have

    // Ensure that cleanTokenValues() does not alter this token value.

    rather than 

    //Ensure that the cleanTokenValues() does not alter this token value.

    in tests/src/Kernel/PathautoTokenTest.php. It looks better grammatically.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    48 pass
  • Pipeline finished with Failed
    over 1 year ago
    Total: 342s
    #70537
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    48 pass
  • Pipeline finished with Success
    about 1 year ago
    Total: 391s
    #75929
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    48 pass
  • Pipeline finished with Success
    about 1 year ago
    Total: 313s
    #79099
  • Comment about 1 year ago →
    🇷🇺Russia zniki.ru

    Update MR, add phpcs.xml file and exclude rules that will be fixed in different issues.
    Gitlab CI check phpcs passed.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    48 pass
  • Pipeline finished with Success
    about 1 year ago
    Total: 449s
    #80010
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    48 pass
  • Pipeline finished with Success
    about 1 year ago
    #85012
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    48 pass
  • Comment about 1 year ago →
    🇷🇺Russia zniki.ru

    Removed changes from PathautoWidget.php because there is separate task 📌 Remove leftover from src/PathautoWidget.php Active .

  • Pipeline finished with Success
    about 1 year ago
    Total: 296s
    #89786
  • Pipeline finished with Success
    10 months ago
    Total: 166s
    #203744
  • Status changed to Needs work 9 months ago
  • Comment 9 months ago →
    a.aaronjake

    Hi @Nikolay Shapovalov,

    Your latest changes on MR66 was applied successfully, however one error still not fixed. Please see below:

    pathauto git:(0f4b566) curl https://git.drupalcode.org/project/pathauto/-/merge_requests/66.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6204    0  6204    0     0  17368      0 --:--:-- --:--:-- --:--:-- 18034
patching file pathauto.module
patching file src/AliasCleanerInterface.php
patching file src/AliasUniquifier.php
patching file src/AliasUniquifierInterface.php
patching file tests/src/Functional/PathautoNodeWebTest.php
patching file tests/src/FunctionalJavascript/PathautoUiTest.php
patching file tests/src/Kernel/PathautoTokenTest.php
➜  web git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig modules/contrib/pathauto/ --sniffs="Drupal.Files.LineLength"

FILE: ...o-site/drupal-orgissue/web/modules/contrib/pathauto/src/PathautoWidget.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 35 | WARNING | Line exceeds 80 characters; contains 146 characters
--------------------------------------------------------------------------------

Time: 666ms; Memory: 12MB

    Kindly check

    Thanks,
    Jake

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024