- Issue created by @tedbow
- Status changed to Postponed
11 months ago 1:09am 28 December 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Postponing on π Test converted on module on gitlabci on core 11.x Needs work which ensure that module is completely compatible with 11.x first. We can't currently test the module against core 11.x in drupalci and even if we could it would not be the converted core version
- Status changed to Active
11 months ago 1:42am 29 December 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
I am working on π Test converted on module on gitlabci on core 11.x Needs work , it not committed but the problem should not affect all the build tests. Therefore we can start to work on this issue.
- Merge request !5976Contrib: Issue #3411241: Expand ConverterCommand documentation to make it... β (Closed) created by tedbow
- Status changed to Needs work
11 months ago 3:22am 29 December 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Ok the build tests fail which was expected. We will probably need to open up a contrib issue to fix the module. The we can run the conversion from the branch on core issue and push up to this branch. If we can get the build tests passing on both the drupalci in the contrib version and gitlab here then I think we can call that fixed enough to commit to the contrib issue.
π Exceptions in batch no longer are shown on the page when Javascript is disabled Needs work might still affect the build tests for Automatic Updates but once π Test converted on module on gitlabci on core 11.x Needs work is fixed we will apply the patch for this issue directly in the conversion script. Regardless though this issue should not affect the Package manager build test because don't use the batch form system in those. So until #3411110 we can just worry about getting the Package Manager build test passing.
- πΊπΈUnited States tedbow Ithaca, NY, USA
I think the error we are getting
Fail Other phpunit-10.xml 0 Drupal\Tests\package_manager\Build\
PHPUnit Test failed to complete; Error: PHPUnit 9.6.15 by Sebastian
Bergmann and contributors.Testing Drupal\Tests\package_manager\Build\PackageInstallTest
FF 2 / 2
(100%)Time: 00:21.850, Memory: 12.00 MB
There were 2 failures:
1)
Drupal\Tests\package_manager\Build\PackageInstallTest::testPackageInstall
COMMAND: COMPOSER_MIRROR_PATH_REPOS=1 composer create-project
drupal/recommended-project project --stability dev --repository
'{"type":"path","url":"composer/Template/RecommendedProject"}'
OUTPUT:
ERROR: Creating a "drupal/recommended-project" project at "./project"
Installing drupal/recommended-project
(dev-59106db9170de044e42da516409f74c77b9992d0)
- Installing drupal/recommended-project
(dev-59106db9170de044e42da516409f74c77b9992d0): Mirroring from
composer/Template/RecommendedProject
Created project in
/tmp/build_workspace_21df0330a51859a5f17fd595455ba17boYGMnu/project
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.Problem 1
- Root composer.json requires drupal/core-recommended * -> satisfiable
by drupal/core-recommended[dev-59106db9170de044e42da516409f74c77b9992d0].
- drupal/core-recommended dev-59106db9170de044e42da516409f74c77b9992d0
requires drupal/core 11.x-dev -> found
drupal/core[dev-59106db9170de044e42da516409f74c77b9992d0] but it does not
match the constraint.Failed asserting that 2 matches expected 0.
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94
/builds/issue/drupal-3411111/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php:307
/builds/issue/drupal-3411111/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php:297
/builds/issue/drupal-3411111/core/modules/package_manager/tests/src/Build/TemplateProjectTestBase.php:501
/builds/issue/drupal-3411111/core/modules/package_manager/tests/src/Build/TemplateProjectTestBase.php:332
/builds/issue/drupal-3411111/core/modules/package_manager/tests/src/Build/PackageInstallTest.php:19
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/TextUI/Command.php:97Points to the fact we need fix this first on this core issue.
I opened π Build tests fail on core merge requests Active in the contrib module for the changes we need there and will update the instructions there for pushing the changes here
- Status changed to Fixed
11 months ago 8:38pm 29 December 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Marking as fixed becasuse the build tests passed on the last test run.
- Status changed to Active
11 months ago 9:01pm 29 December 2023 - Merge request !5981Issue #3411111 Automatic Updates core conversion test β (Open) created by tedbow