Automatic Updates Gitlab Conversion test issue

Created on 28 December 2023, 11 months ago
Updated 29 December 2023, 11 months ago

Problem/Motivation

This issue is for testing the conversion of the Automatic Updates and Package Manager modules into the core merge requests versions for ✨ Add Alpha level Experimental Package Manager module Needs review and ✨ Add Alpha level Experimental Automatic Updates module Needs work

Although we have conversion script and we test that conversion using our gitlabci pipeline in the contrib module that will never be 100% the same as the core merge request because of different gitlab setups between contrib and core.

To avoid extra noise on the core merge request issues we will use this issue make sure we keep the core merge request version passing. This will especially useful when are making changes to the conversion script itself or when are in the middle of contrib issues and we want to test whether a change will break the core merge requests before commit the contrib issue.

Steps to reproduce

Proposed resolution

Use this as scratch issue to make sure core merge request always pass tests

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Active

Version

11.0 πŸ”₯

Component
OtherΒ  β†’

Last updated about 8 hours ago

Created by

πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tedbow
  • Status changed to Postponed 11 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    Postponing on πŸ“Œ Test converted on module on gitlabci on core 11.x Needs work which ensure that module is completely compatible with 11.x first. We can't currently test the module against core 11.x in drupalci and even if we could it would not be the converted core version

  • Status changed to Active 11 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    I am working on πŸ“Œ Test converted on module on gitlabci on core 11.x Needs work , it not committed but the problem should not affect all the build tests. Therefore we can start to work on this issue.

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • Pipeline finished with Failed
    11 months ago
    Total: 287s
    #69344
  • Pipeline finished with Failed
    11 months ago
    Total: 1332s
    #69347
  • Status changed to Needs work 11 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    Ok the build tests fail which was expected. We will probably need to open up a contrib issue to fix the module. The we can run the conversion from the branch on core issue and push up to this branch. If we can get the build tests passing on both the drupalci in the contrib version and gitlab here then I think we can call that fixed enough to commit to the contrib issue.

    πŸ› Exceptions in batch no longer are shown on the page when Javascript is disabled Needs work might still affect the build tests for Automatic Updates but once πŸ“Œ Test converted on module on gitlabci on core 11.x Needs work is fixed we will apply the patch for this issue directly in the conversion script. Regardless though this issue should not affect the Package manager build test because don't use the batch form system in those. So until #3411110 we can just worry about getting the Package Manager build test passing.

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    I think the error we are getting

    Fail Other phpunit-10.xml 0 Drupal\Tests\package_manager\Build\
    PHPUnit Test failed to complete; Error: PHPUnit 9.6.15 by Sebastian
    Bergmann and contributors.

    Testing Drupal\Tests\package_manager\Build\PackageInstallTest
    FF 2 / 2
    (100%)

    Time: 00:21.850, Memory: 12.00 MB

    There were 2 failures:

    1)
    Drupal\Tests\package_manager\Build\PackageInstallTest::testPackageInstall
    COMMAND: COMPOSER_MIRROR_PATH_REPOS=1 composer create-project
    drupal/recommended-project project --stability dev --repository
    '{"type":"path","url":"composer/Template/RecommendedProject"}'
    OUTPUT:
    ERROR: Creating a "drupal/recommended-project" project at "./project"
    Installing drupal/recommended-project
    (dev-59106db9170de044e42da516409f74c77b9992d0)
    - Installing drupal/recommended-project
    (dev-59106db9170de044e42da516409f74c77b9992d0): Mirroring from
    composer/Template/RecommendedProject
    Created project in
    /tmp/build_workspace_21df0330a51859a5f17fd595455ba17boYGMnu/project
    Loading composer repositories with package information
    Updating dependencies
    Your requirements could not be resolved to an installable set of packages.

    Problem 1
    - Root composer.json requires drupal/core-recommended * -> satisfiable
    by drupal/core-recommended[dev-59106db9170de044e42da516409f74c77b9992d0].
    - drupal/core-recommended dev-59106db9170de044e42da516409f74c77b9992d0
    requires drupal/core 11.x-dev -> found
    drupal/core[dev-59106db9170de044e42da516409f74c77b9992d0] but it does not
    match the constraint.

    Failed asserting that 2 matches expected 0.

    /builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94
    /builds/issue/drupal-3411111/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php:307
    /builds/issue/drupal-3411111/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php:297
    /builds/issue/drupal-3411111/core/modules/package_manager/tests/src/Build/TemplateProjectTestBase.php:501
    /builds/issue/drupal-3411111/core/modules/package_manager/tests/src/Build/TemplateProjectTestBase.php:332
    /builds/issue/drupal-3411111/core/modules/package_manager/tests/src/Build/PackageInstallTest.php:19
    /builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
    /builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
    /builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
    /builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/TextUI/Command.php:144
    /builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/TextUI/Command.php:97

    Points to the fact we need fix this first on this core issue.

    I opened πŸ› Build tests fail on core merge requests Active in the contrib module for the changes we need there and will update the instructions there for pushing the changes here

  • Pipeline finished with Failed
    11 months ago
    Total: 1262s
    #69623
  • Pipeline finished with Failed
    11 months ago
    #69633
  • Status changed to Fixed 11 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    Marking as fixed becasuse the build tests passed on the last test run.

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • Status changed to Active 11 months ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • Pipeline finished with Failed
    11 months ago
    Total: 224s
    #69663
  • Pipeline finished with Failed
    11 months ago
    Total: 1396s
    #69665
  • Pipeline finished with Failed
    11 months ago
    Total: 193s
    #72309
  • Pipeline finished with Failed
    11 months ago
    #72317
  • Pipeline finished with Failed
    10 months ago
    #79346
  • Pipeline finished with Failed
    8 months ago
    Total: 1542s
    #113257
  • Pipeline finished with Failed
    8 months ago
    Total: 1260s
    #124411
  • Pipeline finished with Failed
    8 months ago
    Total: 1331s
    #128974
  • Pipeline finished with Failed
    8 months ago
    Total: 863s
    #135662
  • Pipeline finished with Failed
    8 months ago
    Total: 186s
    #135672
  • Pipeline finished with Failed
    8 months ago
    Total: 179s
    #135674
  • Pipeline finished with Failed
    8 months ago
    Total: 711s
    #135679
  • Pipeline finished with Failed
    8 months ago
    Total: 740s
    #135690
  • Pipeline finished with Failed
    8 months ago
    Total: 724s
    #136564
  • Pipeline finished with Failed
    7 months ago
    #140860
  • Pipeline finished with Failed
    7 months ago
    Total: 825s
    #140876
  • Pipeline finished with Failed
    7 months ago
    Total: 685s
    #140890
  • Pipeline finished with Success
    7 months ago
    Total: 1350s
    #140961
  • Pipeline finished with Failed
    7 months ago
    Total: 958s
    #149532
  • Pipeline finished with Failed
    7 months ago
    Total: 188s
    #151052
  • Pipeline finished with Failed
    7 months ago
    #151071
  • Pipeline finished with Running
    7 months ago
    #151090
  • Pipeline finished with Success
    7 months ago
    Total: 990s
    #151418
  • Pipeline finished with Failed
    7 months ago
    Total: 709s
    #156806
Production build 0.71.5 2024