Contrib.social

tests fail on core merge requests

Open on Drupal.org →
Created on 29 December 2023, 6 months ago
Updated 24 April 2024, 2 months ago

Problem/Motivation

In 📌 [PP-1] Fix build tests for Automatic Updates core Gitlab Postponed the build tests are failing with

Fail Other phpunit-10.xml 0 Drupal\Tests\package_manager\Build\
PHPUnit Test failed to complete; Error: PHPUnit 9.6.15 by Sebastian
Bergmann and contributors.

Testing Drupal\Tests\package_manager\Build\PackageInstallTest
FF 2 / 2
(100%)

Time: 00:21.850, Memory: 12.00 MB

There were 2 failures:

1)
Drupal\Tests\package_manager\Build\PackageInstallTest::testPackageInstall
COMMAND: COMPOSER_MIRROR_PATH_REPOS=1 composer create-project
drupal/recommended-project project --stability dev --repository
'{"type":"path","url":"composer/Template/RecommendedProject"}'
OUTPUT:
ERROR: Creating a "drupal/recommended-project" project at "./project"
Installing drupal/recommended-project
(dev-59106db9170de044e42da516409f74c77b9992d0)
- Installing drupal/recommended-project
(dev-59106db9170de044e42da516409f74c77b9992d0): Mirroring from
composer/Template/RecommendedProject
Created project in
/tmp/build_workspace_21df0330a51859a5f17fd595455ba17boYGMnu/project
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Root composer.json requires drupal/core-recommended * -> satisfiable
by drupal/core-recommended[dev-59106db9170de044e42da516409f74c77b9992d0].
- drupal/core-recommended dev-59106db9170de044e42da516409f74c77b9992d0
requires drupal/core 11.x-dev -> found
drupal/core[dev-59106db9170de044e42da516409f74c77b9992d0] but it does not
match the constraint.

Failed asserting that 2 matches expected 0.

/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94
/builds/issue/drupal-3411111/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php:307
/builds/issue/drupal-3411111/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php:297
/builds/issue/drupal-3411111/core/modules/package_manager/tests/src/Build/TemplateProjectTestBase.php:501
/builds/issue/drupal-3411111/core/modules/package_manager/tests/src/Build/TemplateProjectTestBase.php:332
/builds/issue/drupal-3411111/core/modules/package_manager/tests/src/Build/PackageInstallTest.php:19
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/builds/issue/drupal-3411111/vendor/phpunit/phpunit/src/TextUI/Command.php:97

There may be other problem once we get past this first on but 

drupal/core-recommended dev-59106db9170de044e42da516409f74c77b9992d0
    requires drupal/core 11.x-dev -> found
    drupal/core[dev-59106db9170de044e42da516409f74c77b9992d0] but it does not
    match the constraint.

Points to the fact that difference in the core merge request running in core clone will affect our build tests.

We should use this issue for any changes we need to get our build test passing in 📌 [PP-1] Fix build tests for Automatic Updates core Gitlab Postponed

Steps to reproduce

Proposed resolution

  1. Work on changes need to this module in this merge request.
  2. Convert the module using a local core clone using the MR on 📌 [PP-1] Fix build tests for Automatic Updates core Gitlab Postponed

    Run the conversion as:
    composer core-convert ~/sites/d-core 3411111-auto-updates-build-tests 3411392-core-mr-build-tests --core_target_branch=11.x --skip_core_checks

    We use --skip_core_checks because of 📌 Run core code quality checks on the core converted version of the module Postponed but that isn't for this issue.

  3. Push the core clone changes to the core clone and check build tests for Package Manager and Automatic Updates in the gitlab pipeline on 📌 [PP-1] Fix build tests for Automatic Updates core Gitlab Postponed

    Other tests will fail because of 📌 Test converted on module on gitlabci on core 11.x Needs work and other issues but this issue is only about our build tests.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

3.1

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024