[1.0.x] Zoom video D10

Thank you for applying!

Branch names must have a name that ends with the literal .x. The main branch will be supported from drupal.org in future, but at the moment cannot be used to create project releases.

Hello @apaderno, Thank you for your reply. I’ve updated the branching in the project repo: https://git.drupalcode.org/project/zoom_video
Tell me if I can do anything else.

Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml zoom_video/

FILE: zoom_video/src/ZoomMeetingSDKRequest.php                                                        
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES                                                                                         
--------------------------------------------------------------------------------
  8 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. 
 58 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters                                                               
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY                                                                            
--------------------------------------------------------------------------------
                                                                                                                                      
                                                                                                                                      
FILE: zoom_video/src/Controller/ZoomVideoController.php                                               
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES                                                                                                      
--------------------------------------------------------------------------------
  5 | ERROR | [x] When importing a class with "use", do not include a leading \                                                       
  6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Json.         
 27 | ERROR | [x] Doc comment short description must end with a full stop                                                             
 39 | ERROR | [x] Parameter comment must end with a full stop
 87 | ERROR | [x] Expected newline after closing brace
 90 | ERROR | [x] Expected 1 blank line after function; 0 found
 91 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: zoom_video/src/ZoomMeetingSDKRequestInterface.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\JsonResponse.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Hello @vishalkadam, thanks for the review. I have updated the repo: https://git.drupalcode.org/project/zoom_video with all fixes for the phpcs

Hello, @vishalkadam, @apaderno. I have added a new release of the module; please check and let me know what I can fix or add if needed.

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance

src/Controller/ZoomVideoController.php

    if (isset($error['error'])) {
      $this->logger->error($error['error']);
    }

The first argument passed to logger methods that log a message must be a literal string. Passing a dynamic string is considered a security issue.

I am changing priority as per Issue priorities → .

This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application. If you are no longer pursuing this application then I mark it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to set the issue status to Needs work or Needs review, depending on the current status of your code.

Hello there, I had no time to finish this task before, but now I have added new release: https://www.drupal.org/project/zoom_video/releases/1.3.2 → and the repo: https://git.drupalcode.org/project/zoom_video
Let me know if I can do anything else.

src/Controller/ZoomVideoController.php

Since that class does not use any method from the parent class, it does not need to use ControllerBase as parent class. Controllers do not need to have a parent class; as long as they implement \Drupal\Core\DependencyInjection\ContainerInjectionInterface, they are fine.

    if ($response->getStatusCode() !== 200) {
      $this->logger->error('Unknown error occurred.');
    }

The previously committed code was the following one.

    if ($response->getStatusCode() !== 200) {
      $this->logErrorResponse($response);
    }

There is no need to give a too generic error code. It is sufficient the dynamic part is passed as placeholder.

Hello there, I have added a new release: https://www.drupal.org/project/zoom_video/releases/1.3.3 → .
Let me know if there are still bugs.

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank the dedicated reviewers as well.

Automatically closed - issue fixed for 2 weeks with no activity.