- Issue created by @catch
- Status changed to Needs review
6 months ago 10:16pm 21 December 2023 - π¬π§United Kingdom catch
This is stacked on π Flood database backend ::isAllowed() should call ::ensureTableExists() Fixed due to the performance test changes, but the runtime code changes are independent.
- π¬π§United Kingdom catch
Adding screenshots from local performance test traces showing the DELETE query disappears.
- Status changed to RTBC
6 months ago 5:30pm 22 December 2023 - Status changed to Fixed
6 months ago 6:41pm 22 December 2023 - π¬π§United Kingdom longwave UK
Also makes sense to me, can't really see this making a difference in the real world but if it can make tests slightly faster then all the better.
Committed and pushed 8e5acc674b to 11.x and 595dce06b7 to 10.2.x. Thanks!
-
longwave β
committed 595dce06 on 10.2.x
Issue #3410419 by catch: Only clear flood attempts when necessary during...
-
longwave β
committed 595dce06 on 10.2.x
-
longwave β
committed 8e5acc67 on 11.x
Issue #3410419 by catch: Only clear flood attempts when necessary during...
-
longwave β
committed 8e5acc67 on 11.x
- π¬π§United Kingdom catch
Found some more queries to get rid of :) π Optimize user logins by avoiding duplicate entity queries Needs work .
Just one database query is usually a millisecond or so, but the more we get rid of, the easier it is to see any other extraneous queries on top. I think I'm up to 3-4 now including two entity queries, which could end up 10ms or so off logins.
- π©πͺGermany Fabianx
Looks good, but one typo nit in the docs:
bu -> but
(https://git.drupalcode.org/project/drupal/-/commit/8e5acc674b6394a83249f...)
- Status changed to Fixed
6 months ago 11:39pm 5 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.