- Issue created by @catch
- Status changed to Postponed
over 1 year ago 8:26am 28 July 2023 - Status changed to Active
about 1 year ago 8:49pm 3 October 2023 - Status changed to Needs review
about 1 year ago 11:28pm 28 November 2023 - 🇬🇧United Kingdom catch
Implemented this. Only a lines on top of 📌 Allow assertions on the number of database queries run during tests RTBC .
- 🇮🇹Italy mondrake 🇮🇹
Interesting... maybe in the future we could build over ✨ [PP-1] Introduce a Connection::executeDdlStatement method Active and the dynamic queries API to provide more metadata as to the type of statement being executed - Data Definition (DDL), Data Manipulation (DML), etc...
See https://github.com/doctrine/dbal/blob/3.7.x/src/Connection.php#L1163-L1182 for definitions
- 🇬🇧United Kingdom catch
If possible it would be great to at least get INSERT vs SELECT into the query events, both for assertions and for scannability here, but I'm not sure if we have access to that in the spot where those are populated.
- 🇮🇹Italy mondrake 🇮🇹
We could by implementing some self describing metadata in the Database\Query classes and their extensions, and passing those into the events. Not immediate, but surely possible.
- Status changed to Postponed
about 1 year ago 3:57pm 5 December 2023 - 🇺🇸United States smustgrave
based on the IS this is postponed on 📌 Allow assertions on the number of database queries run during tests RTBC which is up for review but may be out of my wheelhouse but will try and keep an eye on it.
- Status changed to Needs review
about 1 year ago 3:13pm 6 December 2023 - 🇬🇧United Kingdom catch
- Status changed to RTBC
about 1 year ago 6:46pm 6 December 2023 - 🇺🇸United States smustgrave
Much easier to review. THanks for also updating issue summary.
- Status changed to Fixed
12 months ago 8:16am 20 December 2023 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 0907775505 to 11.x and 571aeb51d8 to 10.2.x. Thanks!
-
alexpott →
committed 571aeb51 on 10.2.x
Issue #3377657 by catch, mondrake: Add database query spans to otel...
-
alexpott →
committed 571aeb51 on 10.2.x
-
alexpott →
committed 09077755 on 11.x
Issue #3377657 by catch, mondrake: Add database query spans to otel...
-
alexpott →
committed 09077755 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.