- Issue created by @Summit
- Status changed to Needs review
12 months ago 11:40am 4 January 2024 - 🇮🇳India Tirupati_Singh
Hi @Summit @shobhit_juyal, upgraded module to drupal 10 version. Please review the MR.
- 🇳🇱Netherlands Summit
Hi,
I cloned the MR with GIT Clone https://git.drupalcode.org/project/hideblock.git, right? Thanks for building!But then using drupal 10.2.1 I got "This version is not compatible with Drupal 10.2.1 and should be replaced."
greetings, Martijn
- 🇮🇳India Tirupati_Singh
Hi @Summit, you have to checkout to this branch 3410046-drupal-10-version after cloning.
- 🇳🇱Netherlands Summit
Hi,
Could you please tell me the exact terminal commands, to checkout 3410046-drupal-10-version please?
Thanks!
greetings, - 🇮🇳India Tirupati_Singh
Run this command after cloning
git checkout 3410046-drupal-10-version. You can also check the current branch usinggit branchcommand. - Status changed to RTBC
7 months ago 11:56am 28 May 2024 Hi, @Tirupati_Singh
After applying your patch the module is now compatible with D10, I've also reviewed your MR and the changes looks fine to me.
It correctly incorporates Drupal once function and correct namespaces along with version requirement.
Hence moving it to RTBC++
Attaching before and after screenshots for reference!