editor_load() typehint is wrong: $format_id is integer, not string

I have modified the argument's comment. Apply against 10.0.x branch.

We should see what's calling it with a string and determine if that's incorrect.

Also would have to look at when that typehint was added if there was discussion about int vs string, which should be documented.

Actually, this seems like a very obvious, trivial mistake. Text formats had numerical IDs in Drupal 7. They don't in Drupal >=8.

No further research necessary IMO.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Keshav Patel → made their first commit to this issue’s fork.

Patch Rerolled and all checks passed. please review.

Reroll seems fine

Is it ever really int any more? Can we set it to string only?

Will try and take a deeper look tomorrow

So looking into editor_filter_xss() there's a line

$editor = $format ? editor_load($format->id()) : NULL;

and id() can actually return string|int|null so guess int can still be passed.

That looks like a bug in editor_filter_xss(), it should check isNew() before trying to load. Or if not, it should specify string|int|null. But I think we should just type hint on string here.