- Issue created by @deepakkm
- 🇮🇳India prashant.c Dharamshala
Prashant.c → made their first commit to this issue’s fork.
- Status changed to Needs review
about 1 year ago 10:48am 12 December 2023 - 🇮🇳India prashant.c Dharamshala
Incorporated a .gitlab-ci.yml file into the project's root directory by utilizing the Drupal Association's template.gitlab-ci.yml contents. Continuously learning about it as I progress.
Thanks
- Status changed to Needs work
12 months ago 11:05am 23 December 2023 - 🇦🇹Austria drunken monkey Vienna, Austria
Thanks!
Could you please create a merge request so this can be tested? If the tests pass, I guess we can just merge this.However, one important point is that we currently have automatic testing configured → for different setups – two tested weekly, and one for each patch, MR and commit. Is it possible to set up something like that in GitLab CI, too? I wouldn’t want to use actual functionality. (Could be a follow-up, though, before we disable the old DrupalCI tests.)
- last update
12 months ago 34 pass - thakurnishant_06 India
Hi @drunken-monkey,
Yes, in GitLab CI, we can configure automated testing for various setups similar to what we have with DrupalCI. We can utilize Scheduled pipelines and refer to https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → .
-
drunken monkey →
committed 57168d65 on 8.x-1.x authored by
Prashant.c →
Issue #3408112 by Prashant.c, thakurnishant_06, drunken monkey: Added...
-
drunken monkey →
committed 57168d65 on 8.x-1.x authored by
Prashant.c →
- 🇦🇹Austria drunken monkey Vienna, Austria
Good to know, thanks!
Merged. Thanks again!Unfortunately, there seems to be some problem with the GitLab CI pipeline, which failed even though the DrupalCI tests all passed → . Maybe we need to manually start the
chromedriver
background process to allow JS tests to run?I would actually have thought that d.o would show such a test failure in the issue, but apparently not – or maybe just not for the issue adding the
.gitlabci.yml
file? Otherwise, I wouldn’t have merged this, of course.
Anyways, we need to fix this before we can really switch to GitLab CI.Also, side note: Do you know whether there is a way to still get notified via mail when a pipeline fails? That was a very important feature of DrupalCI, in my opinion.
In any case, thanks a lot again for your help! - thakurnishant_06 India
It is possible that manually starting the chromedriver background process could serve as a solution . Upon closer look it seems tests runs differently between the legacy test bots and GitLabCI .
As for the notifications, GitLab does offer email notifications for pipeline failures. You can configure these notifications in your GitLab account settings under the Notifications section. Please refer to the following article Notification emails
- last update
12 months ago 34 pass - Status changed to Needs review
12 months ago 5:15pm 6 January 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
OK,
chromedriver
does seem to be running (would have been very weird if not), but it’s started slightly differently apparently. By adding--no-sandbox
to thechromedriver
command I use locally, I could indeed reproduce this error.
No idea how to override the command used in GitLab CI, but let’s give it a try. Otherwise, I might need to adapt the test to pass instead. (Same if there is a good reason that this--no-sandbox
flag is included.)Thanks again for the other tips, very helpful!
- Status changed to Needs work
12 months ago 5:41pm 6 January 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
Hm, no, that doesn’t seem to have been it, fails exactly the same way. But I’m not sure whether that’s because the CI didn’t pick up the changed
chromedriver
command or whether that just didn’t fix the issue. I also cannot find anywhere in the pipeline’s output the actual command used. Do you have any idea how I can check this? - 🇮🇳India vipin.mittal18 Greater Noida
vipin.mittal18 → made their first commit to this issue’s fork.
- last update
10 months ago 34 pass - 🇦🇹Austria drunken monkey Vienna, Austria
@vipin.mittal18: Could you please explain what you did and why?
- last update
10 months ago 34 pass - Status changed to Needs review
10 months ago 10:27am 3 March 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
Reverted your change, since it seemed detrimental. Also, I think I figured out why the test is failing. Fingers crossed.
- last update
10 months ago 34 pass - Status changed to RTBC
10 months ago 10:08am 5 March 2024 - 🇮🇳India vipin.mittal18 Greater Noida
GitLab CI is passing, and coding standards can be addressed separately.
- Status changed to Needs work
10 months ago 4:15am 6 March 2024 - thakurnishant_06 India
There are still some phpstan issues that needs to be addressed before merging.
Setting the status back to NW - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & sqlite-3.27last update
9 months ago Not currently mergeable. - last update
9 months ago 34 pass -
drunken monkey →
committed bef0915c on 8.x-1.x
Issue #3408112 by drunken monkey, Prashant.c, thakurnishant_06: Added...
-
drunken monkey →
committed bef0915c on 8.x-1.x
- Status changed to Fixed
9 months ago 10:38am 11 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.