- Issue created by @deepakkm
- last update
9 months ago 31 pass, 2 fail - Status changed to Needs review
9 months ago 11:06am 7 February 2024 - Status changed to Needs work
9 months ago 6:11am 14 February 2024 - Status changed to Closed: outdated
7 months ago 9:15am 5 April 2024 - Status changed to Needs work
5 months ago 3:03pm 28 June 2024 - đź‡đź‡şHungary Balu Ertl Budapest 🇪🇺
(I hope reopening an old but relevant ticket is not a problem rather than opening a new one instead and generating more noise in the issue queue.)
While working on the 📌 Automated Drupal 11 compatibility fixes for captcha Needs work @japerry → correctly pointed out that this project first needs its testing suite to pass cleanly on the default branch HEAD. Currently, this is not the case due to an error as per the latest pipeline (#138492 at the time of writing).
I chose this ticket for reviving because the message of the commit triggering the failed pipeline suggests that it was the latest point when changes were made on Apr 5, 2024.
To sum up, I think first we need to fix the erroneous test, get the pipeline green, and then get back to the topic of D11 compatibility.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @Balu Ertl you're right. Sorry for my mistake!
- đź‡đź‡şHungary Balu Ertl Budapest 🇪🇺
Balu Ertl → changed the visibility of the branch 2.x to hidden.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
5 months ago Waiting for branch to pass - đź‡đź‡şHungary Balu Ertl Budapest 🇪🇺
I want to open a debate on the practical value of these two tests:
\Drupal\Tests\image_captcha\Functional\ImageCaptchaInstallationTest::
testInstallation()
andtestUninstallation()
.To my understanding, ensuring that sub-modules cannot get installed without their dependencies also being installed belongs to the responsibility domain of the core. (I found the
\Drupal\Tests\TestRequirementsTrait::
checkModuleRequirements()
the most relevant here.) If my knowledge is correct, then I'd like to hear some arguments in favour of keeping these two tests.Why is it a problem?
The wording of some localization UI strings (eg. “Some required modules must be…”) was corrected to the good between minor core versions:
Therefore our single test suite of this contrib module is unable to cover both “current” and “previous minor” environments at the same time – one will always fail.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
5 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
5 months ago Waiting for branch to pass - First commit to issue fork.
- Status changed to Fixed
5 months ago 4:49am 2 July 2024 -
japerry →
committed 1ec15303 on 2.x authored by
deepakkm →
Issue #3407854: Switch over to GitLab CI
-
japerry →
committed 1ec15303 on 2.x authored by
deepakkm →
Automatically closed - issue fixed for 2 weeks with no activity.