Maximum number of bundle sub-menus does not account for setting zero

Prashant.c → made their first commit to this issue’s fork.

@simonbaese

Made change to use !empty() . Please review.

Thanks

Resolved all threads. Please test your suggestions before pushing code to the branch. Please review.

@simonbaese, I've tested the MR- MR !65 mergeable on the Drupal - 10.2 version, the patch was applied successfully. After applying the patch, the issue was fixed partially for me, The issue was fixed for the "Structure menu's" list but not applied on other menus- sharing attached before & after results for reference-

Testing Steps:

• Enable/Install Admin Toolbar Module.
• Go to> Admin>Configuration/User interface/Admin Toolbar Tools settings-
• Set the value of 'Maximum number of bundle sub-menus to display' to 0 & save.
• Check the Menus for the applied changes- Added Before Results.
• Download the Patch & Apply.
• Check the Menus after applying the Patch- Added After Results.

Hi
Tested MR !65 on the drupal 10.2
The patch applied successfully...

Test Result:
The issue fixed partially using the MR !65
After the patch fix is applied for Structure some menus and other menus are not fixed.

Attaching screenshot for reference
#7 comments
Moving to "needs work"

@Sandeep_k & @Kanchan Bhogade Please read the issue description carefully. This issue aims to fix a bug in the current implementation. It does not intend to extend or change the menu behaviour. The max bundle number setting is currently not used for user bundles. Please open another issue, if you like to change that and do not bloat this issue. Please describe the expected behaviour when posting screenshots. Especially the second set of screenshots it is not clear.

Looks good to me! The issue fork solves the problem described in the issue body.

Comments #7 and #8 may be valid, but are out of scope for this task.

Marking RTBC.