- Issue created by @lauriii
- Status changed to RTBC
9 months ago 8:12am 8 December 2023 - Status changed to Needs review
9 months ago 11:02am 13 December 2023 - 🇸🇰Slovakia poker10
There seems to be other non-silenced deprecation message, for example
Drupal\Component\Assertion\Handle
:trigger_error(__NAMESPACE__ . '\Handle is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Instead, use assert_options(ASSERT_EXCEPTION, TRUE). See https://www.drupal.org/node/3105918', E_USER_DEPRECATED);
Wouldn't it be better to expand the scope to search/fix also others, if there are any left? Or is it OK to fix just this one? Thanks!
- Status changed to Needs work
9 months ago 1:33pm 13 December 2023 - 🇺🇸United States smustgrave
There are actually dozens of these, several in the stream wrapper folder. Not sure if we want to do all at once but definitely think we could group a few together.
Always wondered why we request deprecation tests and now I know :) haha
- 🇳🇱Netherlands Spokje
Wouldn't it be better to expand the scope to search/fix also others, if there are any left? Or is it OK to fix just this one? Thanks!
Got nerd-sniped and wondered if coder could help us here.
I think it can: https://git.drupalcode.org/issue/drupal-3390360/-/jobs/481429So I believe there are only two, both mentioned in this issue.
There are actually dozens of these, several in the stream wrapper folder. Not sure if we want to do all at once but definitely think we could group a few together.
Those are unsilenced
trigger_error('yadada', E_USER_WARNING);
which is ok, we're after unsilencedtrigger_error('blahblah', E_USER_DEPRECATED);
, the difference being the last argumentE_USER_DEPRECATED
.Now this coder change is a complete hack, would need a separate rule and tests, but it's basically a small change: https://github.com/pfrenssen/coder/compare/8.3.x...Boegie:coder:mustsupr...
Should we open an issue in coder, add an actual polished rule with tests and solve both (then) PHPCS fails when that rule is approved, committed, coder is released, coder version is bumped in core?
- 🇳🇱Netherlands Spokje
Opened ✨ Add sniff for unsilenced deprecation warnings Fixed , just because the code was basically already there.
- 🇳🇱Netherlands Spokje
✨ Add sniff for unsilenced deprecation warnings Fixed just got committed, we're waiting for the next release of coder
- Merge request !8122Resolve #3406971 "Non silenced deprecation message coder" → (Open) created by Spokje
- Merge request !8129Draft: Resolve #3406971 "10.4.x test only non silenced deprecation message coder" → (Open) created by Spokje