Add sniff for unsilenced deprecation warnings

https://github.com/pfrenssen/coder/pull/218

Thanks, just one minor comments from me.

Could this disrupt custom Drupal projects where developers use trigger_error() for deprecations in their own project? Maybe this is not common. Developers can also disable individual rules, so there are workarounds in such a case.

In my projects we don't use trigger_error() and mostly rely on custom PHPStan rules that flag deprecated function invocations.

Thanks for the review @Klausi!

Added fixer and addressed your comments.

Could this disrupt custom Drupal projects where developers use trigger_error() for deprecations in their own project?

If and when core turns this rule on it would.

Maybe this is not common.

Found 5 occurrences with http://codcontrib.hank.vps-private.net/search?text=E_USER_DEPRECATED&fil...
One of them (bat) even has a convenient // phpcs:ignore straight above it.

So I would say not very common indeed, and as you said disable-able if no @ there on purpose.

Ok, then let's do this! Thanks a lot for your patience and rerolling.

Forgot credits.

Automatically closed - issue fixed for 2 weeks with no activity.