- Issue created by @quietone
- First commit to issue fork.
- Merge request !5650Issue #3405662: Remove use of Tour module in ToolbarCacheContextsTest.php β (Open) created by smustgrave
- Status changed to Needs review
about 1 year ago 4:16am 2 December 2023 - π³πΏNew Zealand quietone
Whoa, that was a fast reply!
I left a question in the MR
- πΊπΈUnited States smustgrave
I couldn't find a module that setting a permission generates a cache tag like the existing test.
- Status changed to RTBC
about 1 year ago 7:57pm 8 December 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
This looks good to me, I confirmed that comment module wasn't already used in the test.
Straight 1:1 swap.
- Status changed to Fixed
12 months ago 8:03am 21 December 2023 - π¬π§United Kingdom catch
I thought entity_test might do this, but it doesn't provide an admin menu link, so don't think that will work. I think we should do the 1-1 swap since adding the extra bits to entity_test now would only save doing them later, if at all.
Committed/pushed to 11.x (which will become 10.3.x too), thanks!
Automatically closed - issue fixed for 2 weeks with no activity.