- Issue created by @joachim
- 🇮🇳India Akhil Babu Chengannur
Not able to find entity_load() method in drupal 10/11. Is it a drupal 7 method?
- 🇮🇳India Akhil Babu Chengannur
Found it in d7 https://api.drupal.org/api/drupal/includes%21common.inc/function/entity_.... SO changing the version
- 🇬🇧United Kingdom joachim
No, this is on D11.
I made a typo -it's editor_load().
- Merge request !5724Issues/3404975: Document ID relationship of editor and filter format entities. → (Open) created by Akhil Babu
- 🇮🇳India Akhil Babu Chengannur
Not sure where to document the ID relationship. I added it as a comment in id() method of editior entity.
Also added a description under the text editor selection area when creating/editing text formats. - Status changed to Needs review
9 months ago 3:34pm 7 December 2023 - Status changed to Needs work
9 months ago 4:05pm 7 December 2023 - 🇺🇸United States smustgrave
Could the issue summary be updated to match proposed solution please.
- 🇬🇧United Kingdom joachim
Thanks for the MR.
I would also add something to the Editor class docs, to explain that editor entities are in a 1-1 relationship with formats and have matching IDs.
As for the UI text -- I'm not sure whether we discourage use of the term 'plugin' in UI text. Also this issue is about code documentation, rather than UI.
IS already says "This should be documented on the Editor entity class.".
- Status changed to Needs review
9 months ago 3:27am 8 December 2023 - 🇮🇳India Akhil Babu Chengannur
Thanks @jaochim. Moved the comment to class doc of Editor entity.
- Status changed to Needs work
9 months ago 1:09pm 8 December 2023 - Status changed to Needs review
9 months ago 4:41am 12 December 2023 - 🇮🇳India Akhil Babu Chengannur
If the description is not required, then let's just remove it
- Status changed to RTBC
9 months ago 2:03pm 12 December 2023 - Status changed to Fixed
9 months ago 7:57am 21 December 2023 - 🇬🇧United Kingdom catch
Hopefully will go when we do 🌱 [META] Discuss: merge the Editor config entity into the FilterFormat config entity Active . Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.