- Issue created by @lejosne.powerling
- Issue was unassigned.
- Status changed to Needs work
about 1 year ago 6:14am 29 November 2023 - 🇮🇳India vishal.kadam Mumbai
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tmgmt_powerling/ FILE: tmgmt_powerling/tmgmt_powerling.routing.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 18 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction -------------------------------------------------------------------------------- FILE: tmgmt_powerling/config/schema/tmgmt_powerling.schema.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: tmgmt_powerling/tmgmt_powerling.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically -------------------------------------------------------------------------------- FILE: tmgmt_powerling/src/Plugin/tmgmt/Translator/PowerlingTranslator.php -------------------------------------------------------------------------------- FOUND 325 ERRORS AND 3 WARNINGS AFFECTING 205 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 35 | ERROR | [x] Opening brace should be on the same line as the declaration 58 | ERROR | [x] Data types in @var tags need to be fully namespaced 65 | ERROR | [x] Data types in @var tags need to be fully namespaced 79 | ERROR | [x] Data types in @param tags need to be fully namespaced 79 | ERROR | [x] Parameter comment must be on the next line 80 | ERROR | [x] Parameter comment must be on the next line 81 | ERROR | [x] Parameter comment must be on the next line 82 | ERROR | [x] Parameter comment must be on the next line 83 | ERROR | [x] Data types in @param tags need to be fully namespaced 83 | ERROR | [x] Parameter comment must be on the next line 86 | ERROR | [x] Opening brace should be on the same line as the declaration 96 | ERROR | [x] Opening brace should be on the same line as the declaration 109 | ERROR | [x] Opening brace should be on the same line as the declaration 111 | ERROR | [x] Whitespace found at end of line 121 | ERROR | [x] Opening brace should be on the same line as the declaration 137 | ERROR | [x] Opening brace should be on the same line as the declaration 156 | ERROR | [x] Opening brace should be on the same line as the declaration 180 | ERROR | [x] Opening brace should be on the same line as the declaration 195 | ERROR | [x] Opening brace should be on the same line as the declaration 199 | ERROR | [x] Whitespace found at end of line 211 | ERROR | [x] Data types in @var tags need to be fully namespaced 233 | ERROR | [x] Opening brace should be on the same line as the declaration 243 | ERROR | [x] Opening brace should be on the same line as the declaration 256 | ERROR | [x] Data types in @param tags need to be fully namespaced 256 | ERROR | [x] Parameter comment must be on the next line 257 | ERROR | [x] Parameter comment must be on the next line 258 | ERROR | [x] Parameter comment must be on the next line 259 | ERROR | [x] Parameter comment must be on the next line 260 | ERROR | [x] Separate the @param and @return sections by a blank line. 260 | ERROR | [ ] Description for the @return value must be on the next line 261 | ERROR | [x] Separate the @return and @throws sections by a blank line. 261 | ERROR | [x] Data types in @throws tags need to be fully namespaced 262 | ERROR | [x] Data types in @throws tags need to be fully namespaced 265 | ERROR | [x] Opening brace should be on the same line as the declaration 278 | ERROR | [x] Use "elseif" in place of "else if" 306 | ERROR | [x] Use null coalesce operator instead of ternary operator. 311 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 311 | ERROR | [x] Data types in @param tags need to be fully namespaced 311 | ERROR | [x] Parameter comment must be on the next line 312 | ERROR | [ ] Missing parameter comment 313 | ERROR | [x] Separate the @param and @return sections by a blank line. 313 | ERROR | [ ] Description for the @return value is missing 316 | ERROR | [x] Opening brace should be on the same line as the declaration 332 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 332 | ERROR | [x] Data types in @param tags need to be fully namespaced 332 | ERROR | [x] Parameter comment must be on the next line 333 | ERROR | [x] Separate the @param and @return sections by a blank line. 333 | ERROR | [ ] Description for the @return value is missing 336 | ERROR | [x] Opening brace should be on the same line as the declaration 347 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 347 | ERROR | [x] Data types in @param tags need to be fully namespaced 347 | ERROR | [x] Parameter comment must be on the next line 348 | ERROR | [ ] Missing parameter comment 348 | ERROR | [ ] Missing parameter type 349 | ERROR | [ ] Missing parameter comment 350 | ERROR | [ ] Missing parameter comment 351 | ERROR | [x] Separate the @param and @return sections by a blank line. 351 | ERROR | [ ] Description for the @return value is missing 352 | ERROR | [x] Separate the @return and @throws sections by a blank line. 352 | ERROR | [x] Data types in @throws tags need to be fully namespaced 355 | ERROR | [x] Opening brace should be on the same line as the declaration 359 | WARNING | [x] A comma should follow the last multiline array item. Found: NULL 367 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 367 | ERROR | [x] Data types in @param tags need to be fully namespaced 367 | ERROR | [x] Parameter comment must be on the next line 368 | ERROR | [ ] Missing parameter comment 368 | ERROR | [ ] Missing parameter type 369 | ERROR | [x] Separate the @param and @return sections by a blank line. 369 | ERROR | [ ] Description for the @return value is missing 370 | ERROR | [x] Separate the @return and @throws sections by a blank line. 370 | ERROR | [x] Data types in @throws tags need to be fully namespaced 373 | ERROR | [x] Opening brace should be on the same line as the declaration 379 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 379 | ERROR | [x] Data types in @param tags need to be fully namespaced 379 | ERROR | [x] Parameter comment must be on the next line 380 | ERROR | [ ] Missing parameter comment 380 | ERROR | [ ] Missing parameter type 381 | ERROR | [x] Separate the @param and @return sections by a blank line. 381 | ERROR | [ ] Description for the @return value is missing 382 | ERROR | [x] Separate the @return and @throws sections by a blank line. 382 | ERROR | [x] Data types in @throws tags need to be fully namespaced 385 | ERROR | [x] Opening brace should be on the same line as the declaration 391 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 391 | ERROR | [x] Data types in @param tags need to be fully namespaced 391 | ERROR | [x] Parameter comment must be on the next line 392 | ERROR | [ ] Missing parameter comment 392 | ERROR | [ ] Missing parameter type 393 | ERROR | [x] Parameter comment must be on the next line 394 | ERROR | [x] Separate the @param and @return sections by a blank line. 394 | ERROR | [ ] Description for the @return value is missing 395 | ERROR | [x] Separate the @return and @throws sections by a blank line. 395 | ERROR | [x] Data types in @throws tags need to be fully namespaced 398 | ERROR | [x] Opening brace should be on the same line as the declaration 404 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 404 | ERROR | [x] Data types in @param tags need to be fully namespaced 404 | ERROR | [x] Parameter comment must be on the next line 405 | ERROR | [ ] Missing parameter comment 405 | ERROR | [ ] Missing parameter type 406 | ERROR | [x] Parameter comment must be on the next line 407 | ERROR | [ ] Missing parameter comment 407 | ERROR | [ ] Missing parameter type 408 | ERROR | [x] Separate the @param and @return sections by a blank line. 408 | ERROR | [ ] Description for the @return value is missing 409 | ERROR | [x] Separate the @return and @throws sections by a blank line. 409 | ERROR | [x] Data types in @throws tags need to be fully namespaced 412 | ERROR | [x] Opening brace should be on the same line as the declaration 421 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 421 | ERROR | [x] Data types in @param tags need to be fully namespaced 421 | ERROR | [x] Parameter comment must be on the next line 422 | ERROR | [ ] Missing parameter comment 422 | ERROR | [ ] Missing parameter type 423 | ERROR | [x] Parameter comment must be on the next line 424 | ERROR | [ ] Missing parameter comment 424 | ERROR | [ ] Missing parameter type 425 | ERROR | [x] Separate the @param and @return sections by a blank line. 425 | ERROR | [ ] Description for the @return value is missing 426 | ERROR | [x] Separate the @return and @throws sections by a blank line. 426 | ERROR | [x] Data types in @throws tags need to be fully namespaced 429 | ERROR | [x] Opening brace should be on the same line as the declaration 437 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 437 | ERROR | [x] Data types in @param tags need to be fully namespaced 437 | ERROR | [x] Parameter comment must be on the next line 438 | ERROR | [ ] Missing parameter comment 438 | ERROR | [ ] Missing parameter type 439 | ERROR | [ ] Missing parameter comment 439 | ERROR | [ ] Missing parameter type 440 | ERROR | [x] Separate the @param and @return sections by a blank line. 440 | ERROR | [ ] Description for the @return value is missing 441 | ERROR | [x] Separate the @return and @throws sections by a blank line. 441 | ERROR | [x] Data types in @throws tags need to be fully namespaced 444 | ERROR | [x] Opening brace should be on the same line as the declaration 452 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 452 | ERROR | [ ] Missing parameter comment 452 | ERROR | [x] Data types in @param tags need to be fully namespaced 453 | ERROR | [ ] Missing parameter comment 453 | ERROR | [ ] Missing parameter type 454 | ERROR | [ ] Missing parameter comment 454 | ERROR | [ ] Missing parameter type 455 | ERROR | [ ] Missing parameter comment 455 | ERROR | [ ] Missing parameter type 456 | ERROR | [ ] Missing parameter comment 456 | ERROR | [ ] Missing parameter type 457 | ERROR | [ ] Missing parameter comment 457 | ERROR | [ ] Missing parameter type 458 | ERROR | [ ] Missing parameter comment 458 | ERROR | [ ] Missing parameter type 459 | ERROR | [x] Separate the @param and @return sections by a blank line. 459 | ERROR | [ ] Description for the @return value is missing 460 | ERROR | [x] Separate the @return and @throws sections by a blank line. 460 | ERROR | [x] Data types in @throws tags need to be fully namespaced 463 | ERROR | [x] Opening brace should be on the same line as the declaration 491 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 491 | ERROR | [x] Data types in @param tags need to be fully namespaced 491 | ERROR | [x] Parameter comment must be on the next line 492 | ERROR | [x] Parameter comment must be on the next line 493 | ERROR | [x] Separate the @param and @return sections by a blank line. 493 | ERROR | [ ] Description for the @return value is missing 494 | ERROR | [x] Separate the @return and @throws sections by a blank line. 494 | ERROR | [x] Data types in @throws tags need to be fully namespaced 497 | ERROR | [x] Opening brace should be on the same line as the declaration 503 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 503 | ERROR | [x] Data types in @param tags need to be fully namespaced 503 | ERROR | [x] Parameter comment must be on the next line 504 | ERROR | [x] Parameter comment must be on the next line 505 | ERROR | [x] Separate the @param and @return sections by a blank line. 505 | ERROR | [ ] Description for the @return value is missing 506 | ERROR | [x] Separate the @return and @throws sections by a blank line. 506 | ERROR | [x] Data types in @throws tags need to be fully namespaced 509 | ERROR | [x] Opening brace should be on the same line as the declaration 515 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 515 | ERROR | [x] Data types in @param tags need to be fully namespaced 515 | ERROR | [x] Parameter comment must be on the next line 516 | ERROR | [x] Parameter comment must be on the next line 517 | ERROR | [ ] Missing parameter comment 517 | ERROR | [ ] Missing parameter type 518 | ERROR | [x] Separate the @param and @return sections by a blank line. 518 | ERROR | [ ] Description for the @return value is missing 519 | ERROR | [x] Separate the @return and @throws sections by a blank line. 519 | ERROR | [x] Data types in @throws tags need to be fully namespaced 522 | ERROR | [x] Opening brace should be on the same line as the declaration 534 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 535 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 535 | ERROR | [x] Data types in @param tags need to be fully namespaced 535 | ERROR | [x] Parameter comment must be on the next line 536 | ERROR | [x] Parameter comment must be on the next line 537 | ERROR | [ ] Missing parameter comment 537 | ERROR | [ ] Missing parameter type 538 | ERROR | [x] Separate the @param and @return sections by a blank line. 538 | ERROR | [ ] Description for the @return value is missing 539 | ERROR | [x] Separate the @return and @throws sections by a blank line. 539 | ERROR | [x] Data types in @throws tags need to be fully namespaced 542 | ERROR | [x] Opening brace should be on the same line as the declaration 555 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 555 | ERROR | [x] Data types in @param tags need to be fully namespaced 555 | ERROR | [x] Parameter comment must be on the next line 556 | ERROR | [x] Parameter comment must be on the next line 557 | ERROR | [x] Parameter comment must be on the next line 558 | ERROR | [ ] Missing parameter comment 558 | ERROR | [ ] Missing parameter type 559 | ERROR | [x] Separate the @param and @return sections by a blank line. 559 | ERROR | [ ] Description for the @return value is missing 560 | ERROR | [x] Separate the @return and @throws sections by a blank line. 560 | ERROR | [x] Data types in @throws tags need to be fully namespaced 563 | ERROR | [x] Opening brace should be on the same line as the declaration 577 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 577 | ERROR | [x] Data types in @param tags need to be fully namespaced 577 | ERROR | [x] Parameter comment must be on the next line 578 | ERROR | [x] Parameter comment must be on the next line 579 | ERROR | [x] Parameter comment must be on the next line 580 | ERROR | [ ] Missing parameter comment 580 | ERROR | [ ] Missing parameter type 581 | ERROR | [x] Separate the @param and @return sections by a blank line. 581 | ERROR | [ ] Description for the @return value is missing 582 | ERROR | [x] Separate the @return and @throws sections by a blank line. 582 | ERROR | [x] Data types in @throws tags need to be fully namespaced 585 | ERROR | [x] Opening brace should be on the same line as the declaration 599 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 599 | ERROR | [x] Data types in @param tags need to be fully namespaced 599 | ERROR | [x] Parameter comment must be on the next line 600 | ERROR | [x] Parameter comment must be on the next line 601 | ERROR | [x] Parameter comment must be on the next line 602 | ERROR | [x] Separate the @param and @return sections by a blank line. 602 | ERROR | [ ] Description for the @return value is missing 603 | ERROR | [x] Separate the @return and @throws sections by a blank line. 603 | ERROR | [x] Data types in @throws tags need to be fully namespaced 606 | ERROR | [x] Opening brace should be on the same line as the declaration 612 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 612 | ERROR | [x] Data types in @param tags need to be fully namespaced 612 | ERROR | [x] Parameter comment must be on the next line 613 | ERROR | [x] Parameter comment must be on the next line 614 | ERROR | [x] Parameter comment must be on the next line 615 | ERROR | [x] Separate the @param and @return sections by a blank line. 615 | ERROR | [ ] Description for the @return value is missing 616 | ERROR | [x] Separate the @return and @throws sections by a blank line. 616 | ERROR | [x] Data types in @throws tags need to be fully namespaced 619 | ERROR | [x] Opening brace should be on the same line as the declaration 620 | ERROR | [x] Each PHP statement must be on a line by itself 626 | ERROR | [x] Data types in @param tags need to be fully namespaced 626 | ERROR | [x] Parameter comment must be on the next line 627 | ERROR | [x] Parameter comment must be on the next line 628 | ERROR | [x] Parameter comment must be on the next line 629 | ERROR | [x] Parameter comment must be on the next line 630 | ERROR | [x] Separate the @param and @return sections by a blank line. 630 | ERROR | [ ] Description for the @return value must be on the next line 631 | ERROR | [x] Separate the @return and @throws sections by a blank line. 631 | ERROR | [ ] @throws comment must be on the next line 634 | ERROR | [x] Opening brace should be on the same line as the declaration 645 | ERROR | [x] Use "elseif" in place of "else if" 647 | ERROR | [x] Whitespace found at end of line 650 | ERROR | [x] Use "elseif" in place of "else if" 664 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 664 | ERROR | [x] Data types in @param tags need to be fully namespaced 664 | ERROR | [x] Parameter comment must be on the next line 665 | ERROR | [x] Data types in @param tags need to be fully namespaced 665 | ERROR | [x] Parameter comment must be on the next line 666 | ERROR | [x] Parameter comment must be on the next line 667 | ERROR | [x] Parameter comment must be on the next line 668 | ERROR | [x] Separate the @param and @throws sections by a blank line. 668 | ERROR | [x] Data types in @throws tags need to be fully namespaced 671 | ERROR | [x] Opening brace should be on the same line as the declaration 681 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found 688 | ERROR | [x] Data types in @param tags need to be fully namespaced 688 | ERROR | [x] Parameter comment must be on the next line 689 | ERROR | [x] Data types in @param tags need to be fully namespaced 689 | ERROR | [x] Parameter comment must be on the next line 690 | ERROR | [x] Parameter comment must be on the next line 691 | ERROR | [x] Parameter comment must be on the next line 692 | ERROR | [x] Separate the @param and @throws sections by a blank line. 692 | ERROR | [ ] @throws comment must be on the next line 692 | ERROR | [x] Data types in @throws tags need to be fully namespaced 695 | ERROR | [x] Opening brace should be on the same line as the declaration 714 | ERROR | [x] Data types in @param tags need to be fully namespaced 714 | ERROR | [x] Parameter comment must be on the next line 715 | ERROR | [x] Parameter comment must be on the next line 716 | ERROR | [x] Data types in @param tags need to be fully namespaced 716 | ERROR | [x] Parameter comment must be on the next line 717 | ERROR | [x] Separate the @param and @return sections by a blank line. 717 | ERROR | [ ] Description for the @return value must be on the next line 718 | ERROR | [x] Separate the @return and @throws sections by a blank line. 718 | ERROR | [ ] @throws comment must be on the next line 718 | ERROR | [x] Data types in @throws tags need to be fully namespaced 721 | ERROR | [x] Opening brace should be on the same line as the declaration 738 | ERROR | [x] Data types in @param tags need to be fully namespaced 738 | ERROR | [x] Parameter comment must be on the next line 741 | ERROR | [x] Opening brace should be on the same line as the declaration 742 | ERROR | [x] Data types in @var tags need to be fully namespaced 752 | WARNING | [ ] Unused variable $status. 755 | ERROR | [x] Expected newline after closing brace 757 | ERROR | [x] Expected newline after closing brace 784 | ERROR | [x] Data types in @param tags need to be fully namespaced 784 | ERROR | [x] Parameter comment must be on the next line 787 | ERROR | [x] Opening brace should be on the same line as the declaration 812 | ERROR | [x] Data types in @param tags need to be fully namespaced 812 | ERROR | [x] Parameter comment must be on the next line 813 | ERROR | [x] Separate the @param and @throws sections by a blank line. 813 | ERROR | [x] Data types in @throws tags need to be fully namespaced 816 | ERROR | [x] Opening brace should be on the same line as the declaration 819 | ERROR | [x] Data types in @var tags need to be fully namespaced 844 | ERROR | [x] Whitespace found at end of line 853 | ERROR | [ ] Missing parameter comment 853 | ERROR | [x] Data types in @param tags need to be fully namespaced 854 | ERROR | [x] Data types in @param tags need to be fully namespaced 854 | ERROR | [x] Parameter comment must be on the next line 855 | ERROR | [x] Parameter comment must be on the next line 856 | ERROR | [x] Parameter comment must be on the next line 857 | ERROR | [x] Separate the @param and @throws sections by a blank line. 857 | ERROR | [x] Data types in @throws tags need to be fully namespaced 860 | ERROR | [x] Opening brace should be on the same line as the declaration 885 | ERROR | [x] Whitespace found at end of line 895 | ERROR | [x] Data types in @param tags need to be fully namespaced 895 | ERROR | [x] Parameter comment must be on the next line 896 | ERROR | [x] Data types in @param tags need to be fully namespaced 896 | ERROR | [x] Parameter comment must be on the next line 897 | ERROR | [x] Parameter comment must be on the next line 898 | ERROR | [x] Parameter comment must be on the next line 901 | ERROR | [x] Opening brace should be on the same line as the declaration 909 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found 917 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found 927 | ERROR | [x] Data types in @param tags need to be fully namespaced 927 | ERROR | [x] Parameter comment must be on the next line 928 | ERROR | [x] Separate the @param and @return sections by a blank line. 928 | ERROR | [ ] Description for the @return value must be on the next line 929 | ERROR | [x] Separate the @return and @throws sections by a blank line. 929 | ERROR | [x] Data types in @throws tags need to be fully namespaced 932 | ERROR | [x] Opening brace should be on the same line as the declaration 940 | ERROR | [x] Data types in @var tags need to be fully namespaced 966 | ERROR | [x] Expected 1 blank line after function; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 256 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: tmgmt_powerling/src/PowerlingTranslatorUi.php -------------------------------------------------------------------------------- FOUND 11 ERRORS AND 5 WARNINGS AFFECTING 16 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 16 | ERROR | [x] Opening brace should be on the same line as the declaration 24 | ERROR | [x] Opening brace should be on the same line as the declaration 34 | WARNING | [ ] #description values usually have to run through t() for translation 40 | WARNING | [ ] #description values usually have to run through t() for translation 51 | ERROR | [x] Opening brace should be on the same line as the declaration 68 | ERROR | [x] Opening brace should be on the same line as the declaration 104 | ERROR | [x] Opening brace should be on the same line as the declaration 117 | ERROR | [x] Opening brace should be on the same line as the declaration 122 | WARNING | [ ] #description values usually have to run through t() for translation 128 | WARNING | [ ] #description values usually have to run through t() for translation 135 | WARNING | [ ] #description values usually have to run through t() for translation 146 | ERROR | [x] Opening brace should be on the same line as the declaration 159 | ERROR | [x] Opening brace should be on the same line as the declaration 165 | ERROR | [x] Expected 1 blank line after function; 0 found 166 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: tmgmt_powerling/src/Controller/PowerlingController.php -------------------------------------------------------------------------------- FOUND 13 ERRORS AFFECTING 13 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 19 | ERROR | [x] Opening brace should be on the same line as the declaration 32 | ERROR | [x] Parameter comment must end with a full stop 35 | ERROR | [x] Opening brace should be on the same line as the declaration 43 | ERROR | [x] Opening brace should be on the same line as the declaration 50 | ERROR | [x] Doc comment short description must end with a full stop 63 | ERROR | [x] Opening brace should be on the same line as the declaration 85 | ERROR | [x] Expected 1 blank line after function; 2 found 89 | ERROR | [x] Doc comment short description must end with a full stop 100 | ERROR | [x] Opening brace should be on the same line as the declaration 116 | ERROR | [ ] The array declaration extends to column 143 (the limit is 80). The array content should be split up over multiple lines 120 | ERROR | [x] Expected 1 blank line after function; 0 found 121 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- - Status changed to Needs review
about 1 year ago 10:24am 29 November 2023 - 🇫🇷France lejosne.powerling
All PHPCS errors and warnings have been fixed. Only a couple of line-size warnings remain on the README, but that check just does not make sense on that type of file.
- Status changed to Needs work
about 1 year ago 6:01pm 29 November 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- What follows is a quick review of the project; it doesn't mean to be complete
- For each point, the review usually shows some lines that should be fixed (except in the case the point is about the full content of a file); it doesn't show all the lines that need to be changed for the same reason
- A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance
src/Plugin/tmgmt/Translator/PowerlingTranslator.php
public function abortTranslation(JobInterface $job) { $this->messenger()->addWarning('Please contact your Powerling project manager with the order cancellation request.'); return $this->abortJob($job);catch (TMGMTException $e) { $this->messenger()->addError($e->getMessage()); }The first argument passed to messenger methods must be a translatable string.
return AvailableResult::no($this->t('@translator is not available. Make sure it is properly <a href=:configured>configured</a>.', [ '@translator' => $translator->label(), ':configured' => $translator->toUrl()->toString(), ]));A placeholder that starts with a colon must be wrapped in quotes, as described in
FormattableMarkup::placeholderFormat().Use this when using the "href" attribute, ensuring the attribute value is always wrapped in quotes
(Other code lines in the project already do that.)
if ($order['status'] == 'complete') { $job->addMessage($this->t('The order (@order_id) has been marked as completed by using simulate order complete command.', ['@order_id' => $orderId])); }The first argument for
$job->addMessage()must be a literal string, not a translatable string. - Status changed to Needs review
about 1 year ago 2:53pm 4 December 2023 - Status changed to Needs work
about 1 year ago 10:13am 13 December 2023 - 🇫🇷France nikral
Running
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tmgmt_powerlingFILE: contrib/tmgmt_powerling/src/Plugin/tmgmt/Translator/PowerlingTranslator.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------- 939 | WARNING | Only string literals should be passed to t() where possible 981 | WARNING | Only string literals should be passed to t() where possible -------------------------------------------------------------------------------------------------------------------------------- - Status changed to Needs review
about 1 year ago 10:34am 13 December 2023 - 🇫🇷France nikral
Rerunning phpcs, all is fine for me.
- No errors except on README, I don't know if that makes sense.
FILE: modules/contrib/tmgmt_powerling/README.txt --------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES --------------------------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 325 characters 6 | WARNING | Line exceeds 80 characters; contains 89 characters 9 | WARNING | Line exceeds 80 characters; contains 88 characters 10 | WARNING | Line exceeds 80 characters; contains 107 characters 15 | WARNING | Line exceeds 80 characters; contains 272 characters 16 | WARNING | Line exceeds 80 characters; contains 183 characters 20 | WARNING | Line exceeds 80 characters; contains 83 characters 24 | WARNING | Line exceeds 80 characters; contains 411 characters 26 | WARNING | Line exceeds 80 characters; contains 129 characters ---------------------------------------------------------------------------------------- README file extension
I noticed your readme file is .txt but not .md (I don't know what is the recommandation)Let's wait for other reviewers if this should be changed or not.
- 🇫🇷France lejosne.powerling
Makes sense, I have renamed the README.txt to README.md
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.These are some recommended readings to help you with maintainership:
- Dries → ' post on Responsible maintainers
- Maintainership →
- Git version control system →
- Issue procedures and etiquette →
- Maintaining and responding to issues for a project →
- Release naming conventions → .
You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.
I thank also the dedicated reviewers as well.
- Assigned to apaderno
- Status changed to Fixed
10 months ago 3:44pm 18 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.