- Issue created by @sascha_meissner
- Merge request !5519Issue #3403706: After manual resize debounce will cause "choose a block" to not position correctly β (Open) created by sascha_meissner
- Status changed to Needs review
12 months ago 12:20pm 23 November 2023 - π©πͺGermany sascha_meissner Planet earth
The initial patch (removing debounce completely) leads to the dialog not be resizeable anymore itself.. so i now have a new commit which should be way better, e.g adjusting the third parameter of debounce from true to false, seems to work fine.
- Status changed to Needs work
12 months ago 4:19pm 23 November 2023 - πΊπΈUnited States smustgrave
Seems to have a test failure that may not be random (didn't rerun)
But could we get a test to show the bug?
- π©πͺGermany sascha_meissner Planet earth
@smustgrave Do you mean a functional javascript test to test for the wrong positioning like in the video I uploaded? Would you want this to be integrated this into any of the already existing test-classes? IΒ΄m actually not sure why the LayoutBuilderDisableInteractionsTest::testFormsLinksDisabled did fail, nor do I know how to rerun the test without making a new commit.
- πͺπΈSpain adrianabadsimon
I have tested @sascha_meissner's changes, and they work correctly in:
Drupal Version - 10.1.7
PHP Version - 8.1.14 - π¨π¦Canada drclaw
Been down the rabbit hole on this one. Found a few related patches which I've linked.
Looks like this patch reverses this issue π [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() Fixed which is probably why there are test failures. The change to have the off canvas debounce function run immediately (i.e. false -> true) was made to prevent those failures.
I actually think that the issue is with the debounce function itself but that's a whole separate issue - for now this patch fixes the problem even if it's not the final solution! π