After manual resize, debounce will cause "choose a block" to not position correctly

Created on 23 November 2023, 12 months ago
Updated 5 March 2024, 9 months ago

Problem/Motivation

On an edit layout page, when the "choose a block" sidebar dialog is opened and a manual resize happens, the element will not be correctly positioned. You can check the video i upload to see the issue.

Steps to reproduce

Check the video

Proposed resolution

We had this as a requirement to position it "correctly" and i fixed this by removing the debounce from the 'resize.off-canvas' eventhandler within /misc/dialog/off-canvas/js/off-canvas.js - I will try to create a MR showcasing this.

Remaining tasks

The Patch fixes this but iΒ΄m not sure if this also fixes other things or breaks other things. Sure the eventhandler will be fired a lot on manual resize, but i didnt found anything in the issue queue that led to implementing the debounce and must admit itΒ΄s a little overwhelming how all kind of stuff interacts here, eg. dialog/offcanvas/layoutbuileder/admin-theme/jquery-ui/etc Probably the best approach would be to fix this within the debounce function, so that it will actually take the last available value? Is this the correct issue queue for this?
IΒ΄m still posting this here in case anyone else is interested.

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component
Layout builderΒ  β†’

Last updated 13 minutes ago

Created by

πŸ‡©πŸ‡ͺGermany sascha_meissner Planet earth

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024