Fix the issues reported by PHP_CodeSniffer

FILE: /page_not_found_files_reports/page_not_found_files_reports.install ------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] Missing file doc comment 7 | ERROR | [x] Whitespace found at end of line 10 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------ FILE: /page_not_found_files_reports/page_not_found_files_reports.links.menu.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 12 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------ FILE: /page_not_found_files_reports/page_not_found_files_reports.routing.yml ----------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 15 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------ FILE: /page_not_found_files_reports/page_not_found_files_reports.info.yml ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Expected 1 newline at end of file; 3 found ------------------------------------------------------------------------------------------------------------------------ FILE: /page_not_found_files_reports/src/Form/ReportsSettings.php ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------ 50 | WARNING | [x] A comma should follow the last multiline array item. Found: '<a href="/admin/reports/page-not-found-files">Report Link</a>' 55 | WARNING | [ ] #description values usually have to run through t() for translation 56 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 71 | WARNING | [ ] Unused variable $config. ------------------------------------------------------------------------------------------------------------------------ FILE: /page_not_found_files_reports/src/Controller/FilesLogController.php ------------------------------------------------------------------------------------------------------------------------ FOUND 55 ERRORS AND 7 WARNINGS AFFECTING 42 LINES ------------------------------------------------------------------------------------------------------------------------ 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 16 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 17 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 18 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 19 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 59 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 62 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 63 | ERROR | [x] Expected 1 space after IF keyword; 0 found 63 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 66 | WARNING | [x] A comma should follow the last multiline array item. Found: '<h5>Configured link empty files report</h5>' 69 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters 69 | ERROR | [x] Inline comments must start with a capital letter 69 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 77 | ERROR | [x] Expected 1 space after FOR keyword; 0 found 77 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 80 | ERROR | [x] Whitespace found at end of line 81 | ERROR | [x] Inline comments must start with a capital letter 81 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 83 | ERROR | [x] Expected 1 space after IF keyword; 0 found 83 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 83 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 85 | ERROR | [x] Concat operator must be surrounded by a single space 87 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 89 | ERROR | [x] Expected 1 space after IF keyword; 0 found 89 | ERROR | [x] There should be no white space after an opening "(" 90 | ERROR | [x] No space found before comment text; expected "// $url." URL not Exist";" but found "//$url." URL not Exist";" 93 | ERROR | [x] Whitespace found at end of line 96 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 97 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7 99 | WARNING | [x] A comma should follow the last multiline array item. Found: '<h4>Sitemap.xml pages empty files report</h4>' 102 | ERROR | [x] Inline comments must start with a capital letter 102 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 103 | ERROR | [x] Concat operator must be surrounded by a single space 105 | ERROR | [x] Inline comments must start with a capital letter 105 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 108 | ERROR | [x] Inline comments must start with a capital letter 108 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 111 | ERROR | [x] Inline comments must start with a capital letter 111 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 116 | ERROR | [x] Inline comments must start with a capital letter 117 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 120 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters 120 | ERROR | [x] Inline comments must start with a capital letter 120 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 128 | ERROR | [x] Expected 1 space after FOR keyword; 0 found 128 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 131 | ERROR | [x] Whitespace found at end of line 132 | ERROR | [x] Inline comments must start with a capital letter 132 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 134 | ERROR | [x] Expected 1 space after IF keyword; 0 found 134 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 134 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 136 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 140 | ERROR | [x] Expected 1 space after IF keyword; 0 found 140 | ERROR | [x] There should be no white space after an opening "(" 141 | ERROR | [x] No space found before comment text; expected "// $url." URL not Exist";" but found "//$url." URL not Exist";" 144 | ERROR | [x] Whitespace found at end of line 146 | ERROR | [x] Whitespace found at end of line 148 | ERROR | [x] Whitespace found at end of line 148 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 154 | WARNING | [x] A comma should follow the last multiline array item. Found: ) ------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @chancenyasulu
First commit to issue fork.
Assigned to ankithashetty
Comment 7 months ago →
🇮🇳India ankithashetty Karnataka, India
On it.
Merge request !1Issue #3403132: Fixed phpcs issues and refactors certain code. → (Closed) created by ankithashetty
Comment 7 months ago →
🇮🇳India ankithashetty Karnataka, India
Issue was unassigned.
Status changed to Needs review 7 months ago5:10am 22 November 2023
Comment 7 months ago →
🇮🇳India ankithashetty Karnataka, India
Updated IS with all the phpcs issues.

Created MR !1 to fix all the reported issues.
Please Note: Made some additional changes to src/Controller/FilesLogController.php & src/Form/ReportsSettings.php apart from what was reported by phpcs.

src/Controller/FilesLogController.php: we don't need to inject config $container->get('config.factory') again as the parent class already has it.

src/Form/ReportsSettings.php: We can use {@inheritdoc} comment as the parent class already has it. Also, removed validateForm function as we don't have any custom validation written here.

Thanks!
Comment 7 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs work 7 months ago8:41pm 22 November 2023
Comment 7 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs review 7 months ago4:35am 23 November 2023
Comment 7 months ago →
🇮🇳India ankithashetty Karnataka, India
Addressed the comments on MR, thanks!
Status changed to Closed: works as designed 7 months ago1:53pm 27 November 2023
Comment 7 months ago →
🇮🇳India bhojwanipankaj05
1. Fix the issues reported by PHP_CodeSniffer
2. Additional changes implemented like used {@inheritdoc} and removed validateForm function.

@ankithashetty For dependency injection we have to use $container->get('config.factory') inside create function.

Changes implemented on the latest release - https://www.drupal.org/project/page_not_found_files_reports/releases/1.0.2 →
Comment 7 months ago →
System Message
bhojwanipankaj05 → closed merge request !1

Fix the issues reported by PHP_CodeSniffer

Merge Requests

!1Fix the issues reported by PHP_CodeSniffer
Closed

Comments & Activities

Fix the issues reported by PHP_CodeSniffer

Merge Requests

!1Fix the issues reported by PHP_CodeSnifferClosed

Comments & Activities

!1Fix the issues reported by PHP_CodeSniffer
Closed