- Issue created by @finnsky
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 3:55am 20 November 2023 - Status changed to Needs work
about 1 year ago 3:29pm 20 November 2023 - 🇪🇸Spain ckrina Barcelona
Good idea @kostyashupenko! But we've been using
toolbar
on all components so let's usetoolbar-tooltip
instead. Also, remember to rename the file and library :) - 🇪🇨Ecuador jwilson3
Apologies I cant be more active here, but I remember seeing someone wanted to genericize tooltip in a previous issue, so it could be leveraged throughout Drupal UIs. I agree it seems like a good idea.
From issue summary on: ✨ Added tooltip component. Needs review
We see that in the future such a component will appear in the core of the administrative theme:
https://www.drupal.org/project/drupal/issues/3197758 ✨ Create a new component: Toggletip RTBCThus, we must take it out of the general script and styles and keep in mind that it will be used independently. So that later we can easily combine them.
Pros: Obvious simplicity, reusability and independence
So one suggestion might be to rename it something like
.drupal-tooltip
(to namespace it and avoid collisions from other design systems) and then, if required, have specific style overrides for use in the toolbar using BEM, with.drupal-tooltip--toolbar
. - 🇷🇸Serbia finnsky
Yes you are right! It is designed to be later merged with core component. But for now we need small fix to make it work with Bootstrap based themes.
- 🇪🇸Spain ckrina Barcelona
Thanks @jwilson3! We're talking about 2 different components: Tooltip and Toggletip. Their behavior is different: mainly, one appears in hover and the other on click.
Either way, can't be sure the one used here will be moved to its own component in core outside the navigation, so I would keep using the internal naming until this is really the case.
- First commit to issue fork.
- Merge request !144Issue #3402596: Rename .tooltip CSS to .toolbar-tooltip → (Merged) created by AkshayAdhav
- Status changed to Needs review
about 1 year ago 4:02pm 5 December 2023 - 🇮🇳India AkshayAdhav Pune, India 🇮🇳
As per the updated IS, changed
.tooltip
to.toolbar-tooltip
. Created separate branch and MR to avoid confusion. - e50b4807 committed on 1.x
Issue #3402596: Rename .tooltip CSS to .toolbar-tooltip
- e50b4807 committed on 1.x
- Status changed to Fixed
about 1 year ago 5:30pm 5 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.