- Issue created by @dww
- @dww opened merge request.
- Status changed to Needs review
12 months ago 6:10am 10 January 2024 - π¦πΊAustralia mstrelan
MR fixes the strict type errors. Just need someone to review if we're happy with the formatting with sprintf, etc.
- Status changed to RTBC
12 months ago 11:31am 10 January 2024 - π¬π§United Kingdom longwave UK
+1 to removing FormattableMarkup in tests, moreso if it fixes strict typing errors.
Backported to 10.2.x to keep things in sync.
Committed and pushed 8310b5cc76 to 11.x and 7b0634404c to 10.2.x. Thanks!
-
longwave β
committed 7b063440 on 10.2.x
Issue #3402297 by dww: Fix strict type errors in CommentFieldAccessTest...
-
longwave β
committed 7b063440 on 10.2.x
- Status changed to Fixed
12 months ago 6:12pm 12 January 2024 -
longwave β
committed 8310b5cc on 11.x
Issue #3402297 by dww: Fix strict type errors in CommentFieldAccessTest
-
longwave β
committed 8310b5cc on 11.x
- πΊπΈUnited States dww
Thanks!
Adding credit to mstrelan since the code here was originally his from another issue before we split this for easier scope.
Automatically closed - issue fixed for 2 weeks with no activity.