Offering to maintain Simple Popup Blocks

Sent a message to the current maintainer of the project:

Hello Ameer Khan,

i-trokhanenko ( https://www.drupal.org/u/i-trokhanenko → ) has sent you a message
via your contact form ( https://www.drupal.org/user/3087149/contact → ) at
Drupal.org.

If you don't want to receive such e-mails, you can change your settings at
https://www.drupal.org/user/3087149/edit → .

Message:

Hi Ameer,

I would like to become a maintainer of the Simple Popup Blocks module. Please
check the issue
https://www.drupal.org/project/simple_popup_blocks/issues/3401950 💬 Offering to maintain Simple Popup Blocks Active

Thanks,
Ivan

Haven't received from the project maintainer, moving this issue to the Drupal.org project ownership

Project owner and project maintainer have logged in on drupal.org in the past months. I am going to contact them as project moderator.

This is the message I sent to Ameer khan.

Hello Ameer,

I am contacting you because Ivan ( https://www.drupal.org/u/i-trokhanenko → ) offered to maintain Simple Popup Blocks ( https://www.drupal.org/project/simple_popup_blocks → ), a project for which you are project owner and maintainer.

May you post a comment on https://www.drupal.org/project/projectownership/issues/3401950 💬 Offering to maintain Simple Popup Blocks Active about accepting or declining the offer? Without a comment posted in that issue in the next 14 days, Ivan will be probably added as maintainer (with all the permissions on the project).
None of the current maintainers/co-maintainers will be removed by site moderators. Maintainers cannot change the project owner.

I am contacting all people with the explicit permission to administer co-maintainers/maintainers for that project.

Best regards,
Alberto Paderno
-- Drupal.org site moderator
-- Drupal.org project moderator

The status has been changed because we are waiting for a reply.

Hello @i-trokhanenko,
Sure it would be great to have some help. First of all please get involved in the project with good patches and useful comments on issue queues.

Hi @jitesh_1, there are 6 issues in the Simple Popup Blocks queue marked as RTBC, some of them have been sitting there for years. Do you want me to create new RTBC issues and wait years for them to be reviewed/merged?
I'm here to help review and commit patches submitted by the community, as I see that current maintainers don't have time to do so.

List of RTBC issues:
🐛 Uncaught TypeError: $(...).once is not a function with Drupal 10 RTBC - for D10 compatibility, needs to be committed asap
🐛 Require confirmation of deletion RTBC
✨ Improve the accessibility of the modal buttons RTBC
🐛 Warning: htmlspecialchars() expects parameter 1 to be string, array given RTBC
#3311873: Cookie life time is always 100 days →
#3266467: Config schema is missing →

There are also eight issues that need to be reviewed → .
Help is certainly welcome, but asking to see involvement in the project is a rather acceptable request.

Hello,

The issue is still relevant. Since our last follow-up on this issue, no issues have been addressed by the current maintainers.

I reviewed a few issues as requested (see below). @apaderno can you add me as a maintainer to the project please?

🐛 Popup is not display when using delay Needs review
📌 Automated Drupal 11 compatibility fixes for simple_popup_blocks RTBC
🐛 Uncaught TypeError: $(...).once is not a function with Drupal 10 RTBC

Thanks,
Ivan

Moving this issue to the Drupal.org project ownership as I haven't received from the project maintainer in the last two weeks.

jitesh_1 already replied to this issue.

First of all please get involved in the project with good patches and useful comments on issue queues.

I do not see any involvement in the project issue queue, which is what jitesh_1 was asking for before adding you as maintainer. There are some issues which are waiting for somebody to review them.

Hi @apaderno, please check my comment #12 in this issue - https://www.drupal.org/project/simple_popup_blocks/issues/3401950#commen... 💬 Offering to maintain Simple Popup Blocks Active
Also, please check this comment - https://www.drupal.org/project/simple_popup_blocks/issues/3298069#commen... 📌 Automated Drupal 10 compatibility fixes Closed: outdated

Check out the list of issues I've been involved in:

https://www.drupal.org/project/simple_popup_blocks/issues/3298069#commen... 📌 Automated Drupal 10 compatibility fixes Closed: outdated
https://www.drupal.org/project/simple_popup_blocks/issues/3377419#commen... 🐛 Drupal 10 Entity Query error Needs review
https://www.drupal.org/project/simple_popup_blocks/issues/3381678#commen... 🐛 Popup is not display when using delay Needs review
https://www.drupal.org/project/simple_popup_blocks/issues/3434561#commen... 📌 Automated Drupal 11 compatibility fixes for simple_popup_blocks RTBC
https://www.drupal.org/project/simple_popup_blocks/issues/3350919#commen... 🐛 Uncaught TypeError: $(...).once is not a function with Drupal 10 RTBC
https://www.drupal.org/project/simple_popup_blocks/issues/3266467#commen... →

Let me know if that's not enough to become a module maintainer.

Best,
Ivan

Regarding comment #17
50% of those issues were after additional prompting of comment #15 with no time for a maintainer to review them.
83% of them were only since May 1st (over 5 months with no activity from the time the applicant was suggested to be involved and only starting around the time of comment #16)
16% of them (a single issue) was on an already RTBC issue in early 2023 and is the only issue linked that shows any involvement prior to opening an application to adopt.

While the security analysts in me would like to see where this issue goes without interference I am commenting since this is a recent subject on Drupa Slack on if adoption should even be allowed on D.O.

I suggest the users behavior shows they are unfit to adopt the module (and perhaps any other module in the future) if they are unable to follow simple instructions, choose to ignore the module for months and than demand action.

I will also add while there is no evidence this is an attempt to back door a module the behavior should be viewed in light of similar tactics used to perpetrate the Linux XZ backdoor.

Hi @cmlara thank you for the feedback, it's very constructive.

What are the next steps in this issue? Should I move the issue back to the original queue and wait for the module maintainer to review it? I'm not sure what the next steps are if the current maintainer asks for "good patches and useful comments on issue queues". Please advise.

Sorry if I'm rushing this issue, just want to make this module better.

This was mentioned on Slack (but from the security perspective, not directly related to these decisions), but my personal opinion on this is a bit different from @cmlara's (especially when I put aside a bit the security perspective and the mentioned risk).

@jitesh_1 got the maintainership approx. a year ago, see: #3335545: Offering to maintain Simple Popup Blocks → . He have done one commit: https://git.drupalcode.org/project/simple_popup_blocks/-/commits/8.x-2.x .

There is a guide what is the responsibility of a maintainer: https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... → .

So question for @apaderno is - should @jitesh_1 be able to "block" another help offer in this case? I am not entirely sure. Especially taking into account these circumstances and looking at the profile of @i-trokhanenko and @jitesh_1. But yeah, the final decision is in the hands of the moderators.