- Issue created by @phenaproxima
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Seems like a perfect use case for the
lock
service.But can the
drupal
script access that? ๐ค - ๐บ๐ธUnited States phenaproxima Massachusetts
If it fully bootstraps Drupal, which AFAIK it does, then it should be able to access all services.
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
I think we should address this in phase 2.
- First commit to issue fork.
- @robert-arias opened merge request.
- Status changed to Needs review
11 months ago 8:01pm 28 April 2024 - ๐จ๐ทCosta Rica robert-arias
Added locking mechanism in recipe command execution, and tests.
- Status changed to Needs work
11 months ago 12:07am 30 April 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Locks are very tricky when something is batched. Look at the ConfigImporter ... it uses the persistent lock service. We're going to need to do the same.
- ๐ฎ๐ณIndia sriharsha.uppuluri Hyderabad
sriharsha.uppuluri โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia sriharsha.uppuluri Hyderabad
Just updated the MR with latest code, the tests are failing.
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Let's do this issue in core as it is a single well focussed issue. Can someone create a core MR and move the work there...
- Assigned to sriharsha.uppuluri
- Merge request !9483Issue #3401875: Add lock mechanism in recipe command execution โ (Open) created by sriharsha.uppuluri
- Issue was unassigned.
- ๐ฎ๐ณIndia sriharsha.uppuluri Hyderabad
I'm new to the core contribution, setting the status to need review
- Status changed to Needs review
7 months ago 12:55pm 13 September 2024 - Status changed to Needs work
7 months ago 8:19pm 19 September 2024 - ๐บ๐ธUnited States smustgrave
Actually before reviewing could this be cleaned up some.
There are 2 forks with 4 branches and 2 MRs so not clear what's up for review.
- ๐ฎ๐ณIndia sriharsha.uppuluri Hyderabad
As per @alex comment need to consider the core MR
"Let's do this issue in core as it is a single well focussed issue. Can someone create a core MR and move the work there..." - ๐ฎ๐ณIndia sriharsha.uppuluri Hyderabad
Moving the ticket status to Needs Review
- ๐บ๐ธUnited States smustgrave
See 3 tests being added but when I run the test-only feature only 1 is failing testLockPreventsConcurrentExecution. Would expect all the new tests to fail