๐Ÿ‡ฎ๐Ÿ‡ณIndia @sriharsha.uppuluri

Hyderabad
Account created on 10 March 2011, almost 14 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

Uploading the patch with the condition, which is a revert of 6 days back code change

if (is_null($lists)) {
return [];
}
๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

This issue still replicating to me even though patch applied successfully on both 2.x and 3.x failing after removal of following condition

// There was a problem getting lists, which was probably already logged.
if (is_null($lists)) {
return [];
}

https://git.drupalcode.org/project/mailchimp/-/merge_requests/96/diffs?c...

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

Moving the ticket status to Needs Review

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad
.text-full.form-element {
  width: 100%;
}

These styles will not work if the CKEditor5 is rendered, I have attached the screenshots in previoud comment

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

sriharsha.uppuluri โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

As per @alex comment need to consider the core MR
"Let's do this issue in core as it is a single well focussed issue. Can someone create a core MR and move the work there..."

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

After adding the wrapper icon in Editor settings as attached the editor is behaving responsive.


๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

After adding the wrapper icon in Editor settings as attached the editor is behaving responsive. Attached the responsive editor also.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

Paragraphs is having CKEditor responsive issue which is related to a existing ticket.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

Fixed the test case failure issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

sriharsha.uppuluri โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

I'm new to the core contribution, setting the status to need review

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

Just updated the MR with latest code, the tests are failing.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

sriharsha.uppuluri โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

Thank you for the patch; I've successfully ported it, and it's working for me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sriharsha.uppuluri Hyderabad

sriharsha.uppuluri โ†’ made their first commit to this issueโ€™s fork.

Production build 0.71.5 2024