Replace CollegeHumor URLs and logic in core test cases

Looks like it's used a bit more widespread in the test cases, will make it more general.

Pexels won't work as it only supports embedding images.

There we are :) tests are passing again.

Applied the MR and searched for collegehumor + college and all references have been replaced.

The MR is definitely better than what's in HEAD. However, there's still an element of "testing the internet" in there. These are media tests for remote media so I can see where it comes from; however, I wonder if mocked/fixture resources would be preferable. A media subsystem maintainer might be able to give feedback on that point, so tagging and pinging.

Valid point @xjm, but I think that's already being worked on in 📌 Improve oEmbed tests Needs work

Is this issue a duplicate, then, or just intended as an intermediate fix to reduce random fails?

Not really a duplicate, the issue I referenced is not fixing the fact CollegeHumor is no longer a thing. And that other one is fixing more in dept things. This is indeed an attempt to hopefully fix the random failures of this test, and to replace the site that no longer exists with something that does.

The referenced issue will need a rebase if this gets in, happy to do that as well :)

Think the main point for me is, this could cause random failures as the site doesn't exist anymore, so if this helps that then I think it's an incremental improvement at least.

OK, that works for me.

Random fails are critical, so bumping priority.

Thanks!

Thanks @xjm and @smustgrave! I'll convert that other issue to a MR once this got in and rebase it to include those changes and try to continue that issue from there.

But I agree, mocking like the other issue is trying to achieve is the "end game" :)

Based on the above and the presence of the followup, this issue is okay without subsystem maintainer review.

Reviewed closely, and also checked the following to make sure the scope is complete:

[ayrton:maintainer | Thu 12:12:53] $ grep -ri "collegehumor" *
[ayrton:maintainer | Thu 12:14:51] $ find . -name "*colleghumor*" -print

Committed to 11.x and 10.2.x. I also tried to backport it to 10.1.x as a test fix, but it did not cherry-pick cleanly (probably on the dictionary). Setting PTBP for a backport version. Thanks!

Adding a patch as it didn't let me create a new issue fork for 10.1.x.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Bot seems confused. I'll close the MR and see if that helps.

xjm → closed merge request !5405

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Reroll for 10.1 seems good.

Committed the backport to 10.1.x. Thanks!

My pleasure 😉

Automatically closed - issue fixed for 2 weeks with no activity.