- Issue created by @berdir
- last update
about 1 year ago 536 pass - @berdir opened merge request.
- Status changed to Needs review
about 1 year ago 8:35pm 10 November 2023 - π¨πSwitzerland berdir Switzerland
Opened a merge request.
Pipeline with 6.2.x against 10.2.x, everything is failing: https://git.drupalcode.org/issue/webform-3400868/-/jobs/309374
Pipeline with the MR against 10.2.x: not everything is failing: https://git.drupalcode.org/issue/webform-3400868/-/jobs/309454
I expect there might still be some problems, due to the changed field UI for example.
- last update
about 1 year ago 536 pass - last update
about 1 year ago 536 pass - last update
about 1 year ago 536 pass - last update
about 1 year ago 536 pass - last update
about 1 year ago 536 pass - Status changed to RTBC
about 1 year ago 5:41pm 13 November 2023 - π¨πSwitzerland berdir Switzerland
Note that this doesn't update all of these tests forms, there are _dozens_, and still 150+ test fails.
- Status changed to Needs work
about 1 year ago 3:25pm 16 November 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
there are _dozens_, and still 150+ test fails.
π¬
Let's make it easy to see those: π Test Webform against upcoming 10.2.x on GitLab CI β and use concurrency to make tests 6x faster (on GitLab CI) Needs work . The only way that we can be confident that this issue makes all tests pass is if this issue can make those tests green.
Other observations:
- TESTS SHOULD NEVER HAVE FAILED in the first place. Investigated and β¦ opened a new core critical issue, with a root cause analysis here: #3402168-7: Follow-up for #3361534: config validation errors can still occur for contrib modules, disrupting contrib β .
- That being said, it looks like the config schema of
webform
is rather inaccurate, and fixing those inaccuracies is likely to help make the module more stable. It's also likely to result in a better experience for the Config Translation module, for example.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
As of #3402168-17: Follow-up for #3361534: Config validation errors can still occur for contrib modules, disrupting contrib β , π Test Webform against upcoming 10.2.x on GitLab CI β and use concurrency to make tests 6x faster (on GitLab CI) Needs work is passing all of the
10.2.x
tests πWith the exception of unrelated failures (for example,
WebformStatesHiddenTest
andWebformSettingsPreviewTest
fail because it's asserting markup literally instead of using CSS selectors, XPath or DOMDocument β probably these output changes are due to π Upgrade filter system to HTML5 Fixed ). See the results.