- Issue created by @chucksimply
- π©πͺGermany Anybody Porta Westfalica
@chucksimply thanks! Sadly very busy these days, so I won't have time to check this in the next weeks.
Could you perhaps try if these lines broke it?
https://git.drupalcode.org/project/photoswipe/-/merge_requests/73/diffs#...
(51-63)If yes, could you perhaps prepare a MR to review with a fix?
- Status changed to Needs work
over 1 year ago 6:12pm 9 November 2023 - πΊπΈUnited States chucksimply
I'll try and look further into it when I have time. For now, patching 4.0.0 with https://www.drupal.org/project/photoswipe/issues/3343669#comment-14935598 π Photoswipe responsive formatter shows no image, if configured to hide any thumbnail except the first one Fixed fixed both issues.
I think I am having this issue, if I use the regular Photoswipe instead of Photoswipe Responsive the first image can have a different image style. If I use responsive the first image uses the same responsive style as the rest of the images.
- π©πͺGermany Anybody Porta Westfalica
Does sthis still happen with 5.x? Is this still relevant?
If yes, we need a test to show it fails and fix it for the future, please. - π¦πΊAustralia fenstrat Australia
This doesn't appear to be 4.x specific. Rather it looks related to the change in https://git.drupalcode.org/project/photoswipe/-/merge_requests/73/diffs#... which @anybody mentioned above in #2.
When "Override first image thumbnail style" is selected the
$image['#style_name']
shouldn't be changed (as per non responsive) instead$image['#responsive_image_style_id']
should be changed. - π¦πΊAustralia fenstrat Australia
MR!128 fixes the issue.
Looking at the tests in Drupal\Tests\photoswipe\FunctionalJavascript\ResponsiveImageTest it looks like some of that at least could be switched out to a non JS test (to help speed test runs up)? Happy to add another JS test in there for this scenario, but it seems a bit overkill.