- Issue created by @lars.stiebenz
- last update
about 1 year ago 10 pass - @larsstiebenz opened merge request.
- Status changed to Needs review
about 1 year ago 3:49pm 3 November 2023 - last update
about 1 year ago 10 pass - π¨π¦Canada nikathone Ontario
Let see if the tests will pass. Also is there a way you can provide a sample code of how the override is done?
- Status changed to Active
about 1 year ago 4:23pm 3 November 2023 Simple Code for testing (placed in setting.php or settings.local.php):
$config['charts.settings']['advanced']['requirements']['cdn'] = FALSE;
More advanced options are in the documentation β .
Preconditions:
- CDN should be allowed in the advanced configurations.
- Used library should be any but Google (that one lacks the config-check).
- The library itself should not be installed for the test.Testing:
Place the code and go to /admin/reports/status.Results:
Without patch: CDN-warning appears.
With patch: CDN-warning does not appear.Background:
The overrides should work for any of the configurations. The CDN-Option is relatively simple to test since it shows almost directly in the status report.- last update
about 1 year ago 10 pass, 2 fail - last update
about 1 year ago 11 pass - Status changed to Needs review
about 1 year ago 7:22pm 9 November 2023 - π¨π¦Canada nikathone Ontario
If the test pass which I think it will, this should be committed. Also @lars.stiebenz please don't change the version because that's where the commit will be applied to. Also let see if we can get another person than me and you to RTBC. Thanks for the patch.
- First commit to issue fork.
- last update
about 1 year ago 11 pass -
andileco β
committed a2636d4b on 5.0.x authored by
lars.stiebenz β
Issue #3399072 by lars.stiebenz, nikathone: Support Drupal's...
-
andileco β
committed a2636d4b on 5.0.x authored by
lars.stiebenz β
- Status changed to Fixed
about 1 year ago 7:36pm 9 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.