Added dependency injection and resolved coding standard issues for ContentTranslationController

Created on 3 November 2023, about 1 year ago

Problem/Motivation


FILE: /core/modules/content_translation/src/Controller/ContentTranslationController.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------------------------------
 262 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 409 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
 410 | WARNING | [x] There must be no blank line following an inline comment
 410 | WARNING | [ ] There must be no blank line following an inline comment
 442 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
 443 | WARNING | [x] There must be no blank line following an inline comment
 443 | WARNING | [ ] There must be no blank line following an inline comment
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

Time: 128ms; Memory: 12MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

Content translation →

Last updated about 8 hours ago

No maintainer

Created by

🇮🇳India adwivedi008

Live updates comments and jobs are added and updated live.

Dependency Injection (DI)

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Comments & Activities

Issue created by @adwivedi008
Status changed to Needs review about 1 year ago10:16am 3 November 2023
Comment about 1 year ago →
🇮🇳India adwivedi008
Resolved above mentioned issues

Please review
Status changed to Postponed: needs info about 1 year ago10:38am 3 November 2023
Comment about 1 year ago →
cilefen
We fix coding standards issues in Drupal Core methodically. Please locate those “meta” issues for how to help.
Status changed to Postponed about 2 months ago1:43am 28 September 2024
Comment about 2 months ago →
🇳🇿New Zealand quietone
The sniff to detected here is a DrupalPractice sniff, DrupalPractice.Objects.GlobalDrupal, and it is not enabled in core.

For now I will add this as a child to the issue that is working on enabling the DrupalPractice sniffs that make sense for core.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024