- Issue created by @Graber
- Status changed to Needs review
about 1 year ago 9:41am 2 November 2023 - last update
about 1 year ago 6 pass - Status changed to RTBC
10 months ago 8:49am 11 April 2024 - 🇬🇧United Kingdom jaydenpearly
It works but
best and worst values are determined as constant in the patch(100/20). Shouldn't them be calculated as the lowest and highest of all evaluations? Rating and ratingCount values are ok.
+1 for RTBC - First commit to issue fork.
- last update
10 months ago 6 pass - 🇮🇳India sarwan_verma
Hi @Graber, @init90,
Fix the issue and created MR. please review it once. - 🇺🇸United States tr Cascadia
@sarwan_verma: What's the difference between your MR and the patch? Did you try the patch - how did it work? Perhaps you can write a test case for these new tokens if this is something you would like to see added?
- last update
9 months ago 6 pass - last update
9 months ago Patch Failed to Apply - Status changed to Needs review
8 months ago 2:59am 17 May 2024 - Issue was unassigned.
- Status changed to Postponed
5 months ago 5:00am 2 September 2024 - 🇺🇸United States tr Cascadia
Because of 🐛 Fix "Give @title 5/5" rating link Needs review , this MR will need to change $entity_type_id to be $entity_id everywhere. Postponing until that issue is committed.
Again, it would be super nice to have some tests for these tokens. This code is unmaintainable otherwise, and until we have tests we will never know it's working properly and we will never know if some change to Drupal core or this module breaks these tokens.