- Issue created by @chaithanya.m
- Status changed to Needs review
about 1 year ago 8:40am 2 November 2023 - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - Status changed to Needs work
about 1 year ago 10:04am 9 November 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Code review:
-
+++ b/acquia_perz/modules/acquia_perz_push/acquia_perz_push.install @@ -60,3 +60,13 @@ function acquia_perz_push_schema() { + $new_primary_keys = ['entity_id']; + $database->schema()->addPrimaryKey('acquia_perz_push_export_tracking', $new_primary_keys);Move the array into the function, no need to cast it to a variable for single use.
-
+++ b/acquia_perz/modules/acquia_perz_push/acquia_perz_push.install @@ -60,3 +60,13 @@ function acquia_perz_push_schema() { \ No newline at end of fileMissing newline
-
- 🇨🇦Canada scor Toronto
the primary key cannot be entity_uuid because there may be multiple rows with the same entity_uuid but different langcode. we need to introduce a new auto-increment id column.
- Status changed to Fixed
8 months ago 7:06pm 28 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.
