Account created on 15 August 2017, almost 7 years ago
  • Software Engineer at Acquiaย 
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia kk5190

Adding Fix for JS not working properly for lazy loading images on Experience Builder in some cases.

๐Ÿ‡ฎ๐Ÿ‡ณIndia kk5190

Hello Brian,
I retested the issue, and it appears to be functioning correctly in the scenario you mentioned. Could you please provide additional details regarding this? Have we cleared the cache of the website or browser after applying the patch? Providing more information about the site's studio component and the method you're using for enabling lazy loading might assist me in reproducing the issue. Could you also verify in the source if the perz.js file contains the new changes by inspecting it through the developer tools?

๐Ÿ‡ฎ๐Ÿ‡ณIndia kk5190

Adding Fix for JS not working properly for lazy loading images on Experience Builder

๐Ÿ‡ฎ๐Ÿ‡ณIndia kk5190

Removing the call to accessCheck(TRUE) will still result in an error for regular Drupal entities. Itโ€™s important to note that explicitly invoking accessCheck is necessary. Refer to this source: Access checking must be explicitly specified on content entity queries โ†’

The error in the current code arises because the code checks for a non-empty $bundle_property_name before calling accessCheck. However, for Site Studio content components, $bundle_property_name is empty, causing our code to skip adding the access check and resulting in a fatal error. To resolve this, the correct approach is to ensure the access check is called before executing the query, regardless of the value of $property_bundle_name. Therefore, in addition to Martinโ€™s changes, we should also include a call to accessCheck(TRUE). Please review the updated patch provided below. While potential test case failures are uncertain, this solution will function correctly for both component contents and standard Drupal entities.

Production build 0.69.0 2024